fix(Collection): Add noValidate option to Collection#add #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l when adding records
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 95.95% 95.96% +<.01%
==========================================
Files 21 21
Lines 2498 2504 +6
==========================================
+ Hits 2397 2403 +6
Misses 101 101
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we've come into a problem to skip validation of records returned by adapter. Eg. all records received from API should be treated as valid records. Passing
noValidate: truetofind/findAllwas not respected cause property setter getsnoValidateproperty value fromSettable.Settableinstance get's this property from schema definition, which isfalseby default. Hence no matter what value fornoValidatewe pass tofind/findAllit does not affect validation.