implemented coptic calendar #752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Philipp, this is my first try to add the Coptic Calendar to js-joda. |
|
Obviously the PR failed. I don't know how to get those tests running |
pithu
requested changes
Jan 15, 2025
|
|
||
| describe('CopticDate', () => { | ||
| describe('Basic Creation', () => { | ||
| test('should create a valid date', () => { |
| constructor(prolepticYear, month, day) { | ||
| this.prolepticYear = prolepticYear; | ||
| this.month = month; | ||
| this.day = day; |
There was a problem hiding this comment.
getter are required for all 3 parameters prolepticYear(), month() and day()
| * This calendar system is primarily used in Christian Egypt. | ||
| * Dates are aligned such that 0001-01-01 (Coptic) is 0284-08-29 (ISO). | ||
| */ | ||
| class CopticDate { |
There was a problem hiding this comment.
extends ChronoLocalDate missing here
| // Define static property after class declaration | ||
| CopticDate.EPOCH_DAY_DIFFERENCE = 574971 + 40587; // MJD values | ||
|
|
||
| export default CopticDate; |
There was a problem hiding this comment.
you must export the class instead of specifying a default export
| /** | ||
| * A date in the Coptic calendar system. | ||
| */ | ||
| export class CopticDate { |
There was a problem hiding this comment.
Ups, why you defined a duplicate here ?
|
|
||
| return copticEpochDay - CopticChronology.EPOCH_DAY_DIFFERENCE; | ||
| } | ||
| } |
| /** | ||
| * An era in the Coptic calendar system. | ||
| */ | ||
| export class CopticEra { |
There was a problem hiding this comment.
the class should go to an separate file
| // Initialize static properties | ||
| CopticChronology._INSTANCE = new CopticChronology(); | ||
| CopticChronology.INSTANCE = CopticChronology._INSTANCE; | ||
| CopticChronology.EPOCH_DAY_DIFFERENCE = 574971 + 40587; // MJD values |
There was a problem hiding this comment.
Any reason why you defined this one not in CopticDate as in the threeten upstream project ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.