Require 'static on trait objects#1
Merged
Merged
Conversation
Owner
|
Hi Alice, sorry for late reply, I somehow managed to "unwatch" this repo. Thank you for the update and everything you do for the rust community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a struct uses
dyn MyTraitas its last field, there is an implicit'staticbound on the trait object. This means that converting anyT: MyTraitinto such a trait object is not ok. Thus, add a+ 'staticbound to the bounds on the generated methods to check for this unless the trait object contains an explicit lifetime.This was discovered during a crater run of rust-lang/rust#136776.