resync #1
resync #1
Conversation
…work-benchmark into leeoniya-leeoniya/ivi-4
…nchmark into mksunny1-actable
This reverts commit c733e90.
… into atscott-oldnozone
…k into omilli-add-hellajs
…-benchmark into plaited-eirby/plaited-7.0.0
…nto srghma-deku-add
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frameworks/keyed/angular-cf-nozone/src/app/app.component.ts (1)
87-87: Replace 'var' with 'const'.Using
varis flagged by ESLint. For better scoping and to follow modern JavaScript practices, replace withconstsince this variable isn't reassigned.- var a = this.data[1]; + const a = this.data[1];🧰 Tools
🪛 ESLint
[error] 87-87: Unexpected var, use let or const instead.
(no-var)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frameworks/keyed/angular-cf-nozone/src/app/app.component.ts(4 hunks)
🧰 Additional context used
🪛 ESLint
frameworks/keyed/angular-cf-nozone/src/app/app.component.ts
[error] 87-87: Unexpected var, use let or const instead.
(no-var)
🔇 Additional comments (4)
frameworks/keyed/angular-cf-nozone/src/app/app.component.ts (4)
1-1: Updated imports to use newer Angular APIs.The change from
ChangeDetectorReftoApplicationRefaligns with the "no zone" approach for this benchmark implementation, effectively managing manual change detection at the application level rather than component level.
12-15: Component decorator simplified.The component is no longer configured as a standalone component with explicit NgFor import. Ensure that NgFor is properly available through module imports if it's used in the template.
17-17: Modern dependency injection pattern adopted.Using
inject()function instead of constructor injection follows modern Angular best practices introduced in newer versions, making the code more maintainable.
45-45: Change detection strategy updated.All component-level change detection calls have been replaced with application-level ticks. While this approach works well for the "no zone" benchmark, be aware that
applicationRef.tick()triggers change detection for the entire application, which may have different performance characteristics thancdr.detectChanges().Also applies to: 56-56, 61-61, 66-66, 73-73, 78-78, 83-83, 91-91
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cli/zip.js (1)
58-60: Case added for Deku framework with output-es path.The addition of "deku" to use the same output path as "halogen" is a good alignment for consistency. This change properly handles the modernized output structure where these frameworks now use
output-es/bundle.jsinstead of the previous location.For added robustness during transitions, you might consider checking both paths when possible:
case "deku": case "halogen": { addLocalFileIfExists(`${frameworkDir}/output-es/bundle.js`, `${zipFrameworkPath}/output-es`); + // Fallback for older versions that might still use the previous path + addLocalFileIfExists(`${frameworkDir}/output/bundle.js`, `${zipFrameworkPath}/output`); break; }
…k into caseywebdev-master
…plaited/js-framework-benchmark into plaited-feat/plaited-performance-regression-fix
…1/js-framework-benchmark into hman61-doohtml-lite-v0.98.2-april-31-2025
…nto nihil-pro-clean
Summary by CodeRabbit