json_error_max → JSON_ERROR_MAX #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
605d794 to
6f9b1b1
Compare
LB--
approved these changes
Sep 3, 2021
|
Ah, thanks for keeping the old lowercase version. Is there a way to mark macros as deprecated? I suppose I shall simply do so in the documentation, and it can be removed at the next major version increment. |
|
Yes, I think it's best to simply document that in the release notes. I may be wrong, but I suspect that any way to mark the macro as deprecated would be compiler dependant. |
All caps to clarify its constant nature. Keep lowercase for compatibility.
6f9b1b1 to
5be6476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All caps to clarify its constant nature.
Keep lowercase for compatibility.
Fixes #124.