Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CMake support && compiler warnings fixes #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eraxillan
Copy link

Hi, thank you for useful library!
I've done some improvements:

  1. CMake support
  2. Pedantic-mode warnings were eliminated

@eraxillan eraxillan changed the title Dev/improvements CMake support && compiler warnings fixes Jul 5, 2020
Copy link
Member

@LB-- LB-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the break; statements you have added fundamentally change the behavior of the parser. See #88, the fallthroughs are intentional.

The CMake support should also be in a separate PR, consider contributing feedback to #67 instead.

LB-- added a commit to LB--/json-parser that referenced this pull request Aug 14, 2021
Also fixed a couple warnings in the example source that failed the build in -Werror mode.
These fixes are duplicated in json-parser#91
LB-- added a commit that referenced this pull request Aug 14, 2021
Also fixed a couple warnings in the example source that failed the build in -Werror mode.
These fixes are duplicated in #91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants