Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Incorrect page navigation throughout JSON Schema website#1653

Merged
benjagm merged 1 commit intojson-schema-org:mainfrom
Utkarsh-123github:fixNav
Jun 14, 2025
Merged

fix: Incorrect page navigation throughout JSON Schema website#1653
benjagm merged 1 commit intojson-schema-org:mainfrom
Utkarsh-123github:fixNav

Conversation

@Utkarsh-123github
Copy link
Copy Markdown
Member

@Utkarsh-123github Utkarsh-123github commented May 13, 2025

What kind of change does this PR introduce?

Old incorrect navigations :

  • Get Started Overview -> Creating your first Schema
  • Get started overview <- Create your first schema -> Miscellaneous Examples
  • Other examples <- Json schema glossary -> JSON schema keywords
  • JSON schema glossary <- Miscellaneous examples
  • Other examples -> JSON Schema glossary
  • Dialect and vocabulary declaration -> Value restrictions
  • Comments -> Enumerated values
  • JSON schema reference <- Specification overview

Modified Correct navigations :

  • Get started overview -> What is a schema ?
  • The basics <- Create your first schema -> JSON Schema glossary
  • Create your first schema <- JSON schema glossary -> Miscellaneous
  • JSON schema glossary <- Miscellaneous
  • Other examples -> Guides
  • Dialect and vocabulary declaration -> Enumerated and constant values
  • Comments -> Conditional Schema validation
  • Media : String encoding non-JSON data <- Specification Overview

Issue Number:

Sample relevant screenshot is attached below.

Screenshots/videos:
image

If relevant, did you update the documentation?
No

Summary
This PR fixes all the incorrect navigations on JSON Schema Website

Does this PR introduce a breaking change?
No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@Utkarsh-123github Utkarsh-123github requested a review from a team as a code owner May 13, 2025 16:17
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview b6ff0ad

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f06af75) to head (b6ff0ad).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1653   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github
Copy link
Copy Markdown
Member Author

Utkarsh-123github commented May 13, 2025

Hi @DhairyaMajmudar ,
Kindly have a look over and review this PR whenever you have a moment.
Thank you🚀

DhairyaMajmudar
DhairyaMajmudar approved these changes May 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working perfect! Thank you so much @Utkarsh-123github

@Utkarsh-123github Utkarsh-123github moved this to Ready to Merge in PR - Triage Group May 22, 2025
@Utkarsh-123github Utkarsh-123github moved this from Ready to Merge to Waiting for others to Review in PR - Triage Group May 31, 2025
benjagm
benjagm approved these changes Jun 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!

@benjagm benjagm merged commit 6e4ced5 into json-schema-org:main Jun 14, 2025
11 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting for others to Review to Done in PR - Triage Group Jun 14, 2025
@Utkarsh-123github Utkarsh-123github deleted the fixNav branch June 26, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjagm benjagm benjagm approved these changes

@DhairyaMajmudar DhairyaMajmudar DhairyaMajmudar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

PR - Triage Group
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Various incorrect page navigation throughout JSON Schema website

3 participants

@Utkarsh-123github @benjagm @DhairyaMajmudar