Sourcery refactored master branch#1
Open
sourcery-ai[bot] wants to merge 1 commit into
Open
Conversation
| class RL_QG_agent: | ||
| def __init__(self): | ||
| self.model_dir = os.path.join(os.path.dirname(os.path.abspath(__file__)), "Reversi") | ||
| pass # 删掉这句话，并填写相应代码 |
Author
There was a problem hiding this comment.
Function RL_QG_agent.__init__ refactored with the following changes:
- Remove redundant pass statement (
remove-redundant-pass)
This removes the following comments ( why? ):
# 删掉这句话，并填写相应代码
Comment on lines
-18
to
+17
| # 这个函数 主要用于测试， 返回的 action是 0-63 之间的一个数值， | ||
| # action 表示的是 要下的位置。 | ||
| action = 123456789 # 删掉这句话，并填写相应代码 | ||
|
|
||
| return action | ||
| return 123456789 |
Author
There was a problem hiding this comment.
Function RL_QG_agent.place refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# 删掉这句话，并填写相应代码
# 这个函数 主要用于测试， 返回的 action是 0-63 之间的一个数值，
# action 表示的是 要下的位置。
| name = ''.join([g.capitalize() for g in game.split('_')]) | ||
| if obs_type == 'ram': | ||
| name = '{}-ram'.format(name) | ||
| name = f'{name}-ram' |
Author
There was a problem hiding this comment.
Lines 311-491 refactored with the following changes:
- Replace call to format with f-string. (
use-fstring-for-formatting) - Replace if statement with if expression (
assign-if-exp)
This removes the following comments ( why? ):
# somewhat harder because of higher variance:
# probably the hardest because you only get a constant number of rewards in total:
# probably the easiest:
# semi_supervised envs
# A frameskip of 1 means we get every frame
| max_epochs = 100 | ||
|
|
||
| for i_episode in range(max_epochs): | ||
| for _ in range(max_epochs): |
Author
There was a problem hiding this comment.
Lines 15-47 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore) - Replace if statement with if expression (
assign-if-exp) - Replace call to format with f-string. (
use-fstring-for-formatting)
This removes the following comments ( why? ):
# pass
# 调用自己训练的模型
Comment on lines
-40
to
+43
| assert isinstance(board_size, int) and board_size >= 1, 'Invalid board size: {}'.format(board_size) | ||
| assert ( | ||
| isinstance(board_size, int) and board_size >= 1 | ||
| ), f'Invalid board size: {board_size}' | ||
|
|
Author
There was a problem hiding this comment.
Function ReversiEnv.__init__ refactored with the following changes:
- Replace call to format with f-string. (
use-fstring-for-formatting)
Comment on lines
-21
to
+20
| std = np.sqrt(np.mean(np.abs(ys - ys_pred) ** 2)) | ||
| return std | ||
| return np.sqrt(np.mean(np.abs(ys - ys_pred) ** 2)) |
Author
There was a problem hiding this comment.
Function evaluate refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-38
to
+48
| pass | ||
| # 按诗的字数排序 | ||
| poems = sorted(poems, key=lambda line: len(line)) | ||
| # print(poems) | ||
| # 统计每个字出现次数 | ||
| all_words = [] | ||
| for poem in poems: | ||
| all_words += [word for word in poem] | ||
| all_words += list(poem) | ||
| counter = collections.Counter(all_words) # 统计词和词频。 | ||
| count_pairs = sorted(counter.items(), key=lambda x: -x[1]) # 排序 | ||
| words, _ = zip(*count_pairs) | ||
| words = words[:len(words)] + (' ',) | ||
| words = words[:] + (' ',) |
Author
There was a problem hiding this comment.
Function process_poems1 refactored with the following changes:
- Remove redundant pass statement (
remove-redundant-pass) - Replace identity comprehension with call to collection constructor (
identity-comprehension) - Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
Comment on lines
-66
to
+65
| line = line.strip() | ||
| if line: | ||
| if line := line.strip(): |
Author
There was a problem hiding this comment.
Function process_poems2 refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Replace identity comprehension with call to collection constructor (
identity-comprehension) - Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
Comment on lines
-185
to
+188
| if w == start_token or w == end_token: | ||
| if w in [start_token, end_token]: | ||
| break | ||
| shige.append(w) | ||
| poem_sentences = poem.split('。') | ||
| for s in poem_sentences: | ||
| if s != '' and len(s) > 10: | ||
| print(s + '。') | ||
| print(f'{s}。') |
Author
There was a problem hiding this comment.
Function pretty_print_poem refactored with the following changes:
- Replace multiple comparisons of same variable with
inoperator (merge-comparisons) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| """ | ||
| sen_embed = self.word_embedding(input_sentence) | ||
| return sen_embed | ||
| return self.word_embedding(input_sentence) |
Author
There was a problem hiding this comment.
Function word_embedding.forward refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!