Fix Support for PowerShell under Windows with VIM 8+#1326
Open
tiamat18 wants to merge 1 commit intojunegunn:masterfrom
Open
Fix Support for PowerShell under Windows with VIM 8+#1326tiamat18 wants to merge 1 commit intojunegunn:masterfrom
tiamat18 wants to merge 1 commit intojunegunn:masterfrom
Conversation
The following 'vim-plug' commands would fail and/or display errors
when executed on by VIM 8+ on a Windows platform with the 'shell'
option set to 'powershell' or 'pwsh':
- PlugInstall
- PlugUpdate
- PlugClean
- PlugStatus
- PlugDiff
There were two causes for these errors:
- A bug in VIM itself (resolved by patch 9.2.6) with how compound
PowerShell commands are handled by the 'system()' vimscript
function.
- A bug in the 's:vim8' branch of the private 'vim-plug' function
's:spawn()' where the actual command to be executed was escaped
for 'cmd.exe' but the 'cd' prefix added by 's:with_cd()" was escaped
for PowerShell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following 'vim-plug' commands would fail and/or display errors when executed on by VIM 8+ on a Windows platform with the 'shell' option set to 'powershell' or 'pwsh':
There were two causes for these errors:
Describe the details of your PR ...