Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Support for PowerShell under Windows with VIM 8+#1326

Open
tiamat18 wants to merge 1 commit intojunegunn:masterfrom
tiamat18:master
Open

Fix Support for PowerShell under Windows with VIM 8+#1326
tiamat18 wants to merge 1 commit intojunegunn:masterfrom
tiamat18:master

Conversation

@tiamat18
Copy link

The following 'vim-plug' commands would fail and/or display errors when executed on by VIM 8+ on a Windows platform with the 'shell' option set to 'powershell' or 'pwsh':

  • PlugInstall
  • PlugUpdate
  • PlugClean
  • PlugStatus
  • PlugDiff

There were two causes for these errors:

  • A bug in VIM itself (resolved by patch 9.2.6) with how compound PowerShell commands are handled by the 'system()' vimscript function.
  • A bug in the 's:vim8' branch of the private 'vim-plug' function 's:spawn()' where the actual command to be executed was escaped for 'cmd.exe' but the 'cd' prefix added by 's:with_cd()" was escaped for PowerShell.

Describe the details of your PR ...

The following 'vim-plug' commands would fail and/or display errors
when executed on by VIM 8+ on a Windows platform with the 'shell'
option set to 'powershell' or 'pwsh':
  - PlugInstall
  - PlugUpdate
  - PlugClean
  - PlugStatus
  - PlugDiff

There were two causes for these errors:
  - A bug in VIM itself (resolved by patch 9.2.6) with how compound
    PowerShell commands are handled by the 'system()' vimscript
    function.
  - A bug in the 's:vim8' branch of the private 'vim-plug' function
    's:spawn()' where the actual command to be executed was escaped
    for 'cmd.exe' but the 'cd' prefix added by 's:with_cd()" was escaped
    for PowerShell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant