expose skills through the UI #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Jausovec <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for exposing and managing skills through the UI by introducing skill container image references to the agent configuration. Users can now add, validate, and display skills (as container images) for declarative agents.
Key Changes
- Added
SkillForAgentinterface to type definitions withrefsarray and optionalinsecureSkipVerifyflag - Implemented skills UI section in the agent creation/edit form with validation for container image format and duplicates
- Added skills display in the agent details sidebar showing skill count and list
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/types/index.ts | Added SkillForAgent interface and skills field to AgentSpec |
| ui/src/components/sidebars/AgentDetailsSidebar.tsx | Added Skills section to display skill refs with tooltip on hover |
| ui/src/components/AgentsProvider.tsx | Added skillRefs to form data and validation errors |
| ui/src/app/agents/new/page.tsx | Implemented skills input UI with validation for container images and duplicate detection |
| ui/src/app/actions/agents.ts | Added logic to include skills in agent spec when creating/updating agents |
| helm/kagent-crds/templates/kagent.dev_modelconfigs.yaml | Removed unrelated categories field from ModelConfig CRD |
| go/config/crd/bases/kagent.dev_modelconfigs.yaml | Removed unrelated categories field from ModelConfig CRD |
| helm/kagent-crds/templates/kagent.dev_agents.yaml | Large auto-generated CRD update with affinity, tolerations, and nodeSelector fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Peter Jausovec <[email protected]>
aae70e4 to
868850a
Compare
EItanya
approved these changes
Nov 24, 2025
EItanya
pushed a commit
that referenced
this pull request
Nov 25, 2025
Noticed yesterday that the controllers manifests/CRDs were out of date - although it seems like these have since been updated (at least somewhat) by #1111. This PR regenerates them once again and also adds a CI check to try prevent them from drifting. Side Note: I've noticed that the category `kagent` seems to be being constantly added/removed - not sure why this is happening but we should probably look into that. --------- Signed-off-by: Brian Fox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.