Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upgrade trpc-a2a-go to v0.2.5 #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EItanya merged 3 commits into from
Nov 24, 2025
Merged

Upgrade trpc-a2a-go to v0.2.5 #1120

EItanya merged 3 commits into from
Nov 24, 2025
+3 −3

Conversation

@inFocus7
Copy link
Contributor

@inFocus7 inFocus7 commented Nov 20, 2025 •
edited
Loading

Changes

  • Upgrade trcp-a2a-go to v0.2.5 which supports a2a v0.3.0.

Context

Primary reason for this was to have the updated ./well-known/agent-card.json path exposed so that a2a clients that default to this path don't hit issues.

trcp-a2a-go v0.2.5 changes

new features

  • updated agent-card url to ./well-known/agent-card.json (neat!)
    • the old agent card path (./well-known/agent.json) is still being exposed by the server.
  • support GetAgentCard for client
    • added agent card requests for HTTP requests (instead of only json-rpc)
    • supports both new and backwards compatible well-known card paths
  • support header config on client calls (neat!)
    • adds optional request options (e.g. x-user-id, x-custom-header) on the a2a client, allowing passing custom headers
  • added support for extended agent card through authentication
    • shouldn't affect existing configuration. afaict we don't implement/support extended agent cards

fixes

  • fixed a data race issue (memory task manager)
  • fix rpc request id, which was wrongly converted from int to string
  • improved error handling
    • upstream changes safe, have not checked if kagent does specific error checking that may require updating

TLDR; some neat new features. no breaking changes. should be a safe upgrade.

Validation

make delete-kind-cluster create-kind-cluster helm-install build-cli-local
kubectl port-forward -n kagent deployments/kagent-controller 8083 &

both paths good

curl http://localhost:8083/api/a2a/kagent/kgateway-agent/.well-known/agent.json | jq .
curl http://localhost:8083/api/a2a/kagent/kgateway-agent/.well-known/agent-card.json | jq .

Resolves #1118

@inFocus7
upgrade trcp-a2a-go to v0.2.5
3e123c8 
Signed-off-by: Fabian Gonzalez <[email protected]>
@inFocus7
Copy link
Contributor Author

inFocus7 commented Nov 20, 2025 •
edited
Loading 

=== RUN   TestE2EInvokeSTSIntegration
agent.kagent.dev/test-sts-agent condition met
=== RUN   TestE2EInvokeSTSIntegration/sync_invocation
    invoke_api_test.go:208: 
        	Error Trace:	/home/runner/work/kagent/kagent/go/test/e2e/invoke_api_test.go:208
        	            				/home/runner/work/kagent/kagent/go/test/e2e/invoke_api_test.go:710
        	Error:      	Received unexpected error:
        	            	a2aClient.SendMessage: a2aClient.doRequest: http request failed: a2aClient.httpRequestHandler: http request failed: Post "http://172.18.255.1:8083/api/a2a/kagent/test-sts-agent/": context deadline exceeded
        	Test:       	TestE2EInvokeSTSIntegration/sync_invocation
--- FAIL: TestE2EInvokeSTSIntegration (51.09s)
    --- FAIL: TestE2EInvokeSTSIntegration/sync_invocation (33.32s)

I haven't reproduced this test failure locally after running a few times (10). It's a flake, as it passed on the second CI run. Not sure if I should spend time investigating, would leave for reviewer thoughts/feedback 👍🏼

similar issue occurred in another invoke test (not in my pr): ref

@inFocus7 inFocus7 changed the title Upgrade trcp-a2a-go to v0.2.5 Upgrade trpc-a2a-go to v0.2.5 Nov 21, 2025
@inFocus7
empty commit (test)
0da3d62 
Signed-off-by: Fabian Gonzalez <[email protected]>
@inFocus7 inFocus7 marked this pull request as ready for review November 21, 2025 17:11
Copilot AI review requested due to automatic review settings November 21, 2025 17:11
@inFocus7 inFocus7 requested a review from yuval-k as a code owner November 21, 2025 17:11
Copilot AI reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the trpc-a2a-go dependency from v0.2.4 to v0.2.5, primarily to support the updated agent card endpoint path at .well-known/agent-card.json as specified in a2a v0.3.0. The upgrade includes new features such as support for custom headers on client calls and improved error handling, while maintaining backward compatibility with the old .well-known/agent.json path.

Key Changes:

  • Updated trpc-a2a-go dependency to v0.2.5 with support for a2a v0.3.0
  • Includes new agent card endpoint at .well-known/agent-card.json (old path still supported)
  • Adds client-side support for GetAgentCard and custom request headers

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go/go.mod Updated trpc-a2a-go dependency from v0.2.4 to v0.2.5
go/go.sum Updated checksums for the new trpc-a2a-go v0.2.5 package

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@EItanya EItanya merged commit 76fa84c into kagent-dev:main Nov 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@EItanya EItanya EItanya approved these changes

@peterj peterj peterj approved these changes

@ilackarms ilackarms Awaiting requested review from ilackarms ilackarms is a code owner

@yuval-k yuval-k Awaiting requested review from yuval-k yuval-k is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support ./well-known/agent-card.json To Fetch Agent Card

3 participants

@inFocus7 @EItanya @peterj