do not compile natives #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a build failure issue in the rdkafka gem by removing native compilation components from the gemspec. The change prevents the Rakefile from being available in precompiled versions, which was causing build failures as referenced in the linked GitHub issue.
- Removes executables and extensions configuration from gemspec
- Bumps version from 0.22.0 to 0.22.1
- Updates changelog with fix description
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rdkafka.gemspec | Removes gem.executables and gem.extensions lines to prevent native compilation |
| lib/rdkafka/version.rb | Bumps version number to 0.22.1 |
| CHANGELOG.md | Adds changelog entry for version 0.22.1 describing the Rakefile fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While backporting from karafka-rdkafka I accidentally left the extconf reference for Rakefile.
This PR fixes this. Alongside I do need to add tests to make sure that precompiled do not run install.
close #642