verify kafka warnings, verify features #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds feature verification tests for librdkafka to ensure that the compiled library includes all expected builtin features for proper Karafka and rdkafka-ruby functionality. It also integrates Kafka warnings verification into the CI workflows.
- Adds integration tests to verify librdkafka features for producer, consumer, and admin clients
- Sets RDKAFKA_PRECOMPILED environment variable in CI workflows to distinguish build types
- Integrates bin/verify_kafka_warnings script execution into CI workflows
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/integrations/librdkafka_producer_features_spec.rb | Feature verification test for producer client |
| spec/integrations/librdkafka_consumer_features_spec.rb | Feature verification test for consumer client |
| spec/integrations/librdkafka_admin_features_spec.rb | Feature verification test for admin client |
| .github/workflows/ci_macos_arm64.yml | Added RDKAFKA_PRECOMPILED env var for build type detection |
| .github/workflows/ci_linux_ubuntu_x86_64_gnu_complementary.yml | Added Kafka warnings verification and RDKAFKA_PRECOMPILED env var |
| .github/workflows/ci_linux_ubuntu_x86_64_gnu.yml | Added Kafka warnings verification and RDKAFKA_PRECOMPILED env var |
| .github/workflows/ci_linux_ubuntu_aarch64_gnu_complementary.yml | Added Kafka warnings verification and RDKAFKA_PRECOMPILED env var |
| .github/workflows/ci_linux_ubuntu_aarch64_gnu.yml | Added Kafka warnings verification and RDKAFKA_PRECOMPILED env var |
| .github/workflows/ci_linux_debian_x86_64_gnu_complementary.yml | Added Kafka warnings verification and RDKAFKA_PRECOMPILED env var |
| .github/workflows/ci_linux_debian_x86_64_gnu.yml | Added Kafka warnings verification and RDKAFKA_PRECOMPILED env var |
| .github/workflows/ci_linux_alpine_x86_64_musl_complementary.yml | Added Kafka warnings verification and RDKAFKA_PRECOMPILED env var |
| .github/workflows/ci_linux_alpine_x86_64_musl.yml | Added Kafka warnings verification and RDKAFKA_PRECOMPILED env var |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mensfeld
added a commit
to karafka/karafka-rdkafka
that referenced
this pull request
Oct 5, 2025
* small api syncs (karafka#706) * small api syncs * fix branch ref * Update confluentinc/cp-kafka Docker tag to v8.0.1 (karafka#708) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ruby/setup-ruby action to v1.260.0 (karafka#707) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ruby/setup-ruby action to v1.261.0 (karafka#709) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ruby/setup-ruby action to v1.262.0 (karafka#710) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ruby/setup-ruby action to v1.263.0 (karafka#713) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update actions/cache action to v4.3.0 (karafka#714) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * verify kafka warnings, verify features (karafka#715) * Normalize topics names (karafka#717) * normalize topics names * small remarks --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mensfeld
added a commit
to karafka/karafka-rdkafka
that referenced
this pull request
Oct 9, 2025
* small api syncs (karafka#706) * small api syncs * fix branch ref * Update confluentinc/cp-kafka Docker tag to v8.0.1 (karafka#708) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ruby/setup-ruby action to v1.260.0 (karafka#707) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ruby/setup-ruby action to v1.261.0 (karafka#709) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ruby/setup-ruby action to v1.262.0 (karafka#710) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ruby/setup-ruby action to v1.263.0 (karafka#713) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update actions/cache action to v4.3.0 (karafka#714) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * verify kafka warnings, verify features (karafka#715) * Normalize topics names (karafka#717) * normalize topics names * small remarks * stabilize spec (karafka#718) * Update dependency ruby to v3.4.7 (karafka#721) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update peter-evans/repository-dispatch action to v4 (karafka#722) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * v0.22.1 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #696
close #644
should tackle also #644 because of lack of feature parity with defaults