Kaspawalletd: Check validity of addresses in isolation#2105
Open
D-Stacks wants to merge 8 commits into
Open
Conversation
https://github.com/D-Stacks/kaspad into Kaspawalletd--check-If-address-is-valid-kaspa-address
Codecov Report
@@ Coverage Diff @@
## dev #2105 +/- ##
==========================================
- Coverage 59.19% 59.11% -0.08%
==========================================
Files 678 678
Lines 32831 32858 +27
==========================================
- Hits 19434 19424 -10
- Misses 10596 10630 +34
- Partials 2801 2804 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was requested by our vitex gatekeeper, it allows the kaspawallet to check for address validity in isolation, as a safeguard so calls do not fail because of wrong address formating, and as a prerequisit opperation on vitex.