Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add service-account lookup flag #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

Add service-account lookup flag #81

merged 1 commit into from
Aug 4, 2025

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Aug 3, 2025 •
edited by embik
Loading

Summary

If service account from different shards tries to authenticate to different shard (max permission model), other shards always hits root shard first), we get "token rewoked" and we can't resolve the secrets crossshards yet.

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #

Release Notes

Set `--service-account-lookup=false` on shards and root shards to allow cross-shard ServiceAcount tokens

@mjudeikis
add service-account lookup flag
cf810d8 
Signed-off-by: Mangirdas Judeikis <[email protected]>
On-behalf-of: SAP <[email protected]>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2025
@mjudeikis
Copy link
Contributor Author

/retest

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 4, 2025
embik
embik approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 088f72eda18f5da50e3354bfd45bc4ed0736818a

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@mjudeikis mjudeikis mentioned this pull request Aug 4, 2025
Open
1 task
@kcp-ci-bot kcp-ci-bot merged commit ff40aad into kcp-dev:main Aug 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjudeikis @kcp-ci-bot @embik