Issue #8141: Dash validator allowing None values in addition to floats #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validators for dashed linestyles now allow None as an allowed value along with floats through optional `allow_none` kwarg in validate_nseq_float. Other validators that use validate_nseq_float arent affected
|
TravisCI and AppVeyor tests passed on official PR: matplotlib#8196 |
|
You don't want to open/merge the PR here; your |
|
Oh, this fork is really just an internal repo for our school project since the course provided one is private and we'd like a way to both submit real PR's while having a convenient listing of changes made in a single place to show our instructor. Thanks for the advice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validators for dashed linestyles now allow
Noneas an allowed value along with floats if optionalallow_nonekwarg flag invalidate_nseq_float.Other validators that use
validate_nseq_floataren't affected, so this bugfix won't have any breaking changes.