This repository was archived by the owner on Feb 1, 2020. It is now read-only.
Pre-release tags with hyphens are truncated #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SemVer 2 says a "pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers" and identifiers "comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]".
if the version is '0.0.1-foo-bar.baz', the pre-release should be ['foo-bar', 'baz']. Instead, it returns 'foo' - explode('-', $version) evaluates to ['0.0.1', 'foo', 'bar.baz'], and only the first two elements are assigned.
This change will return ['0.0.1', ['foo-bar.baz']], which can then be exploded on '.'
|
Your pull request break existing unit tests. I added a pull request with the addition of unit testing, and modification with the help of your code. |
There was a problem hiding this comment.
Warning, your limit parameter is incorrect :
<?php
print_r(preg_split('/-/', '1.2.3-pre-release', 1));
?>The above example will output, and break the unit testing :
Array
(
[0] => 1.2.3-pre-release
)
But, fix limit to 2 :
<?php
print_r(preg_split('/-/', '1.2.3-pre-release', 2));
?>The above example will output:
Array
(
[0] => 1.2.3
[1] => pre-release
)
Expected return for the need of your pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SemVer 2 says a "pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers" and identifiers "comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]".
if the version is '0.0.1-foo-bar.baz', the pre-release should be ['foo-bar', 'baz']. Instead, it returns 'foo' - explode('-', $version) evaluates to ['0.0.1', 'foo', 'bar.baz'], and only the first two elements are assigned.
This change will return ['0.0.1', 'foo-bar.baz'], which can then be exploded on '.'