Rename customer "Contact" field to "Contact person" - #6079
Open
JoeJoeflyn wants to merge 1 commit into
Open
Conversation
JoeJoeflyn
force-pushed
the
fix/customer_contact_wording
branch
from
August 2, 2026 19:38
33dfc66 to
9f7db24
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6079 +/- ##
============================================
+ Coverage 88.75% 88.81% +0.05%
- Complexity 10090 10093 +3
============================================
Files 889 889
Lines 32152 32163 +11
============================================
+ Hits 28538 28564 +26
+ Misses 3614 3599 -15
🚀 New features to boost your workflow:
|
kevinpapst
requested changes
Aug 5, 2026
kevinpapst
left a comment
Member
There was a problem hiding this comment.
Thank you 👍
I would like to see another approach:
use the bin/console kimai:translations --copy-resname command to copy the contact key to a new contact_info key.
Change the english contact key to Contact person and the de one to Kontaktperson.
Then use the new contact_info key for the InvoiceTemplate label.
That prevents us from having missing translations in both screens and we do not need to remap the Customer key to a different label.
Copy the contact translation key to contact_info for the InvoiceTemplate label, and change the customer contact label to "Contact person" (en) / "Kontaktperson" (de).
JoeJoeflyn
force-pushed
the
fix/customer_contact_wording
branch
from
August 5, 2026 18:53
9f7db24 to
ec4a0ab
Compare
Contributor
Author
|
Thanks, fixed. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5770.
Description
The customer
contactfield stores a person name, but the label "Contact" was ambiguous and could be read as a contact method (email/phone). The same translation key was shared with the InvoiceTemplatecontactfield, which is a free-text textarea with different semantics.Adds a dedicated
contact_persontranslation key for the customer field (form label, detail view, list column header, export column header) while keeping the originalcontactkey for InvoiceTemplate, per the maintainer's plan in #5770.Types of changes
Checklist
composer code-check)