build.gradle (3)

25-28: Prefer Gradle toolchains for JDK provisioning.
Switch to toolchains to ensure JDK 17 is provisioned consistently in CI and dev environments.

-java {
-    sourceCompatibility = JavaVersion.VERSION_17
-    targetCompatibility = JavaVersion.VERSION_17
-}
+java {
+    toolchain {
+        languageVersion = JavaLanguageVersion.of(17)
+    }
+}

---

64-73: Avoid overriding Spring‑managed dependency versions unless necessary.
Consider relying on Spring Boot/Cloud BOMs instead of pinning these versions to reduce drift (spring‑messaging, spring‑data‑elasticsearch, cloud starters, admin client).

If you want centralized control, import the Spring Cloud BOM and drop explicit versions:

dependencyManagement {
  imports {
    mavenBom "org.springframework.cloud:spring-cloud-dependencies:2024.0.3"
  }
}

Then:

-implementation 'org.springframework.data:spring-data-elasticsearch:5.5.4'
+implementation 'org.springframework.data:spring-data-elasticsearch'
-implementation "org.springframework:spring-messaging:6.2.11"
+implementation "org.springframework:spring-messaging"
-implementation "org.springframework.cloud:spring-cloud-starter-config:4.3.0"
+implementation "org.springframework.cloud:spring-cloud-starter-config"
-implementation "org.springframework.cloud:spring-cloud-starter-netflix-eureka-client:4.3.0"
+implementation "org.springframework.cloud:spring-cloud-starter-netflix-eureka-client"
-implementation "org.springframework.cloud:spring-cloud-gateway-mvc:4.3.1"
+implementation "org.springframework.cloud:spring-cloud-gateway-mvc"
-implementation 'de.codecentric:spring-boot-admin-starter-client:3.5.5'
+implementation 'de.codecentric:spring-boot-admin-starter-client'

---

35-38: Remove or update stale springBootVersion property
build.gradle sets springBootVersion = "3.2.1" while the Spring Boot plugin is 3.5.6; no other references were found — remove the unused property or update it if you plan to use it.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

.github/workflows/docker-publish.yml (2)

16-22: Add top‑level concurrency to avoid overlapping image publishes on rapid pushes

Prevents racing pushes for the same ref.

 env:
   REGISTRY: ghcr.io
   IMAGE_NAME: ${{ github.repository }}
 
+concurrency:
+  group: docker-publish-${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 # Only one job for creating and pushing Docker image
 jobs:

---

59-65: Enable Buildx remote cache to speed up subsequent builds

Uses the GitHub Actions cache backend; safe and commonly used with build-push-action.

       - name: Build and push Docker image
         uses: docker/build-push-action@9e436ba9f2d7bcd1d038c8e55d039d37896ddc5d
         with:
           context: .
           push: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
+          cache-from: type=gha
+          cache-to: type=gha,mode=max

src/test/java/edu/kit/datamanager/repo/test/integration/ActuatorPrometheusTest.java (5)

78-80: Remove unused JUnitRestDocumentation Rule

The Rule is declared but not used; drop it to reduce noise.

-  @Rule
-  public JUnitRestDocumentation restDocumentation = new JUnitRestDocumentation();

---

68-74: Consolidate repeated @TestPropertySource annotations

Combine into a single annotation for readability and easier maintenance.

-@TestPropertySource(properties = {"spring.datasource.url=jdbc:h2:mem:db_prometheus;DB_CLOSE_DELAY=-1;MODE=LEGACY;NON_KEYWORDS=VALUE"})
-@TestPropertySource(properties = {"spring.jpa.database-platform=org.hibernate.dialect.H2Dialect"})
-@TestPropertySource(properties = {"spring.jpa.defer-datasource-initialization=true"})
-@TestPropertySource(properties = {"repo.monitoring.enabled=true"})
-@TestPropertySource(properties = {"repo.monitoring.serviceName=base_repo_test"})
-@TestPropertySource(properties = {"management.endpoints.web.exposure.include=prometheus"})
+@TestPropertySource(properties = {
+        "spring.datasource.url=jdbc:h2:mem:db_prometheus;DB_CLOSE_DELAY=-1;MODE=LEGACY;NON_KEYWORDS=VALUE",
+        "spring.jpa.database-platform=org.hibernate.dialect.H2Dialect",
+        "spring.jpa.defer-datasource-initialization=true",
+        "repo.monitoring.enabled=true",
+        "repo.monitoring.serviceName=base_repo_test",
+        "management.endpoints.web.exposure.include=prometheus"
+})

---

96-107: Trim .andDo(print()) to keep CI logs clean

Printing every request clutters logs and slows builds. Keep prints only when debugging failures.

-    this.mockMvc.perform(get("/actuator/beans")).andDo(print()).andExpect(status().isNotFound());
+    this.mockMvc.perform(get("/actuator/beans")).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/caches")).andDo(print()).andExpect(status().isNotFound());
+    this.mockMvc.perform(get("/actuator/caches")).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/conditions")).andDo(print()).andExpect(status().isNotFound());
+    this.mockMvc.perform(get("/actuator/conditions")).andExpect(status().isNotFound());
...apply similarly to the remaining endpoints...

---

110-116: Also assert Prometheus content type; drop print

Prometheus should respond with text/plain (OpenMetrics v0.0.4 exposition). Check compatibility to avoid parameter/charset brittleness.

+import org.springframework.http.MediaType;
@@
-    this.mockMvc.perform(get("/actuator/prometheus")).andDo(print()).andExpect(status().isOk())
+    this.mockMvc.perform(get("/actuator/prometheus")).andExpect(status().isOk())
+            .andExpect(content().contentTypeCompatibleWith(MediaType.TEXT_PLAIN))
             .andExpect(content().string(Matchers.containsString("# TYPE base_repo_test_requests_served_total")))
             .andExpect(content().string(Matchers.containsString("# TYPE base_repo_test_unique_users")))
             .andExpect(content().string(Matchers.containsString("# TYPE base_repo_test_registered_users")))
             .andReturn();

---

93-107: Reduce duplication by looping over non‑exposed endpoints

Keeps the test short and easier to extend.

-    // Check that all other endpoints are not exposed
-    this.mockMvc.perform(get("/actuator/beans")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/caches")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/conditions")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/configprops")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/env")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/loggers")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/heapdump")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/threaddump")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/metrics")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/scheduledtasks")).andDo(print()).andExpect(status().isNotFound());
-    this.mockMvc.perform(get("/actuator/mappings")).andDo(print()).andExpect(status().isNotFound());
+    for (String ep : new String[]{
+            "/actuator/beans", "/actuator/caches", "/actuator/conditions", "/actuator/configprops",
+            "/actuator/env", "/actuator/loggers", "/actuator/heapdump", "/actuator/threaddump",
+            "/actuator/metrics", "/actuator/scheduledtasks", "/actuator/mappings"}) {
+        this.mockMvc.perform(get(ep)).andExpect(status().isNotFound());
+    }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/test/resources/test-config/application-test.properties (1)

38-39: Remove duplicate management property entries.

These two keys are already defined later in this file (Lines 57 and 59), so the later values override these additions. Please drop one set to avoid confusion.

- management.endpoints.web.exposure.include=*
- management.endpoint.health.show-details=always

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro