Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix handling of possible loops in data graphs #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2024
Merged

Fix handling of possible loops in data graphs #187

merged 2 commits into from
Sep 6, 2024

Conversation

Pfeil
Copy link
Member

@Pfeil Pfeil commented Sep 6, 2024 •
edited
Loading

Closes #186

  • extend test to contain this case and check out the behavior
  • fix by ending recursion by filtering out children that are already known

@Pfeil Pfeil added this to the v2.0.0 milestone Sep 6, 2024
@Pfeil Pfeil self-assigned this Sep 6, 2024
@coveralls
Copy link

coveralls commented Sep 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #248

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 90.645%
Totals Coverage Status
Change from base Build #246: 0.03%
Covered Lines: 1589
Relevant Lines: 1753
💛 - Coveralls

@Pfeil
fix: data (entity) graphs with loops were causing stack overflows
9731860 
Fixed and switched from recursive solution to procedural solution.
@Pfeil Pfeil force-pushed the fix-186-handle-loops-in-data-graph branch from 37be0de to 9731860 Compare September 6, 2024 10:50
@Pfeil Pfeil marked this pull request as ready for review September 6, 2024 10:51
@Pfeil Pfeil merged commit 07ae1f4 into main Sep 6, 2024
9 checks passed
@Pfeil Pfeil deleted the fix-186-handle-loops-in-data-graph branch September 6, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Pfeil Pfeil

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

Handle possible loops in data graph (2.0.0-rc4 only)

2 participants

@Pfeil @coveralls