Hotfix 2019.06.06.post0: added long_description_content_type to setup.py #1850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that pypi renders the README correctly
|
I've actually gone ahead and pushed this change to pypi, since it's a doc-only change, but we can still merge it this way. Doc is now beautiful at https://pypi.org/project/python-for-android/2019.6.6.post0/ |
|
We could also have made another release with just that fix e.g. |
|
That also means we should try to build the doc as part as our automated testing process to be sure |
AndreMiras
approved these changes
Jun 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change p4a's code, just fixes how the long_description is rendered on pypi. Currently pypi displays the markdown as plain text, because it tries and fails to render as rst.
See 2019.06.06 pypi release description vs testpypi release where I fixed this.
I think this may as well be a post release thing, since it's a trivial fix.