Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adjust queue proxy metric attributes#16049

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
dprotaso:queue-proxy-attributes
Aug 30, 2025
Merged

Adjust queue proxy metric attributes#16049
knative-prow[bot] merged 1 commit intoknative:mainfrom
dprotaso:queue-proxy-attributes

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Aug 29, 2025 •
edited
Loading

  • Adding the some k8s attributes (k8s pod, container name)

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2025
@knative-prow knative-prow bot requested review from gauron99 and skonto August 29, 2025 20:12
@dprotaso dprotaso force-pushed the queue-proxy-attributes branch from 5a72a70 to a94a584 Compare August 29, 2025 20:15
@dprotaso dprotaso changed the title Adjust queue proxy metric reporting and attributes Adjust queue proxy metric attributes Aug 29, 2025
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Aug 29, 2025

/assign @Cali0707
/cc @evankanderson

@knative-prow knative-prow bot requested a review from evankanderson August 29, 2025 20:15
@dprotaso
Copy link
Member Author

dprotaso commented Aug 29, 2025

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Aug 29, 2025

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member Author

dprotaso commented Aug 29, 2025

/retest

@dprotaso
Copy link
Member Author

dprotaso commented Aug 29, 2025

weird

Warning: Failed to download action 'https://api.github.com/repos/andstor/file-existence-action/tarball/076e0072799f4942c8bc574a82233e1e4d13e9d6'. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
Warning: Back off 12.637 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/andstor/file-existence-action/tarball/076e0072799f4942c8bc574a82233e1e4d13e9d6'. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
Warning: Back off 18.274 seconds before retry.
Error: Action 'https://api.github.com/repos/andstor/file-existence-action/tarball/076e0072799f4942c8bc574a82233e1e4d13e9d6' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.

@dprotaso
Copy link
Member Author

dprotaso commented Aug 29, 2025

retried again and it went green 🤷

evankanderson
evankanderson approved these changes Aug 30, 2025
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

This looks like it's just cleanup, not new attributes?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@evankanderson
Copy link
Member

evankanderson commented Aug 30, 2025

(we already had container name)

@knative-prow knative-prow bot merged commit 109f3f0 into knative:main Aug 30, 2025
69 of 70 checks passed
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Aug 30, 2025

@dprotaso: new pull request created: #16051

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 30, 2025
Merged
@dprotaso
Copy link
Member Author

dprotaso commented Aug 31, 2025

(we already had container name)

Oh where?

@dprotaso dprotaso deleted the queue-proxy-attributes branch August 31, 2025 03:16
@evankanderson
Copy link
Member

evankanderson commented Sep 1, 2025

(we already had container name)

Oh where?

Nevermind, I was reviewing on my phone, and somehow ended up looking at one commit rather than all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson approved these changes

@gauron99 gauron99 Awaiting requested review from gauron99

@skonto skonto Awaiting requested review from skonto

Assignees

@evankanderson evankanderson

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dprotaso @knative-prow-robot @evankanderson @Cali0707