Allow manual scaling of the Pod Autoscaler#16186
Merged
knative-prow[bot] merged 13 commits intoknative:mainfrom Nov 4, 2025
Merged
Allow manual scaling of the Pod Autoscaler#16186knative-prow[bot] merged 13 commits intoknative:mainfrom
knative-prow[bot] merged 13 commits intoknative:mainfrom
Conversation
When creating child resources for a Revisino we now exclude propagating autoscaling annotations. The exception is the KPA for which we do propagate annotations.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16186 +/- ##
==========================================
- Coverage 80.08% 80.03% -0.05%
==========================================
Files 214 214
Lines 16940 13313 -3627
==========================================
- Hits 13566 10655 -2911
+ Misses 3015 2296 -719
- Partials 359 362 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Otherwise if the update fails this can have a side-effect of marking a revision as ready. Specifically when a Deployment has >1 ready Pods it'll mark the Revision as Ready. It's the KPA status propagation that will mark the revision still deploying when it hasn't reached min-scale.
9a83a95 to
9c5da28
Compare
dprotaso
commented
Oct 23, 2025
Member
Author
|
I don't want to merge this the day before the release - moving to the next one |
Member
Author
|
/hold |
Member
Author
|
/hold cancel release is done /assign @Fedosin @linkvt @nader-ziada |
Member
Author
|
/retest Webhook flake |
linkvt
reviewed
Oct 31, 2025
Contributor
linkvt
left a comment
There was a problem hiding this comment.
Looks good to me besides the small comment I made 👍
I'll leave the approve to someone with more experience though.
nader-ziada
reviewed
Nov 3, 2025
nader-ziada
reviewed
Nov 3, 2025
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.