Run HTTPS E2E tests only when HTTPS endpoint is ready#16230
Run HTTPS E2E tests only when HTTPS endpoint is ready#16230knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
|
/remove-approve |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16230 +/- ##
=======================================
Coverage 80.04% 80.04%
=======================================
Files 214 214
Lines 13313 13313
=======================================
Hits 10657 10657
+ Misses 2297 2296 -1
- Partials 359 360 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test https |
|
Should we simplify this and just have IsServiceReady wait for the |
002c7c8 to
2b90e99
Compare
2b90e99 to
0957cb3
Compare
0957cb3 to
bd64903
Compare
Makes sense, just realized |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #14435
Proposed Changes
Testing
I tried to reproduce it locally but didn't see the exact error message. I was able get similar ones though by replicating the E2E environment, scale cert-manager to 0, start the test and scale cert-manager up again after ~10sec or when the logs show errors (happens only in the unfixed code).
Requirement to test is a
config-networklike this and an appropriate cert-manager setup as in the E2E tests which is quite complicated, let me know if you need it.I also thought about adding some kind of polling to start the tests only when the first HTTPS request was successful, I'll add it in case this PR is not enough.
Release Note