Added bindingInfo to binding exception #2123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added DOM element node and binding context info to 'unable to process binding' exception.
Member
|
This was one of the first issues addressed and will definitely be covered in tko. ( when it builds ... Soon! ) this is a pretty innocuous add to ko 3.4 but probably not API compatible going forward. Want to leave it open or wait for tko? |
Author
|
I would like to be included in both versions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DOM element node and binding context info to 'unable to process binding' exception.
With this change we can retrieve more info in exception management:
For example: viewmodel constructor and failing dom element node.
ko.onError = function(e){
console.log({ viewModel : e.bindingInfo.context["$component"].constructor , node : e.bindingInfo.node });
}