fix: check error return from yaml.Encoder.Close() in resolveFile#1664
Merged
imjasonh merged 1 commit intoMay 18, 2026
Merged
Conversation
The yaml.Encoder.Close() method flushes remaining buffered data and returns an error. In resolveFile(), this error was silently discarded, which could cause the function to return incomplete or malformed YAML without any error indication. Check the error and propagate it to the caller. Signed-off-by: Sebastien Tardif <[email protected]>
imjasonh
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveFile()inpkg/commands/resolver.gocallsyaml.Encoder.Close()without checking its error return value. TheClose()method flushes remaining buffered data and can fail; discarding the error means the function may return incomplete YAML to callers without any error indication.This change checks the error from
Close()and propagates it, consistent with howEncode()errors are already handled in the same function.