Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: correctly handle multiline comments in Unions #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

fix: correctly handle multiline comments in Unions #2454

merged 1 commit into from
Jul 25, 2025
+111 −1

Conversation

anor4k
Copy link
Contributor

@anor4k anor4k commented Jul 21, 2025

Fixes #2344

gaborbernat
gaborbernat requested changes Jul 21, 2025
View reviewed changes
Copy link
Collaborator

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add test.

@codecov Codecov
Copy link

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.07%. Comparing base (ec84e8e) to head (0f8c6a5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
tests/parser/test_graphql.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
- Coverage   98.09%   98.07%   -0.03%     
==========================================
  Files          66       66              
  Lines        8307     8318      +11     
  Branches      837      838       +1     
==========================================
+ Hits         8149     8158       +9     
- Misses        115      116       +1     
- Partials       43       44       +1
Flag Coverage Δ
unittests 98.07% <81.81%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #2454 will not alter performance

Comparing anor4k:main (0f8c6a5) with main (ec84e8e)

Summary

✅ 32 untouched benchmarks

@anor4k anor4k requested a review from gaborbernat July 21, 2025 22:19
@anor4k
Copy link
Contributor Author

anor4k commented Jul 21, 2025

test added

@gaborbernat gaborbernat enabled auto-merge (squash) July 25, 2025 13:22
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 25, 2025
View reviewed changes
@gaborbernat gaborbernat merged commit d32cef1 into koxudaxi:main Jul 25, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Produces invalid Python syntax from some multi-line GraphQL comments
2 participants
@anor4k @gaborbernat