Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix refcounts to make develop stable #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
realFlowControl merged 4 commits into from
Oct 17, 2024
Merged

fix refcounts to make develop stable #325

realFlowControl merged 4 commits into from
Oct 17, 2024

Conversation

@realFlowControl
Copy link
Collaborator

@realFlowControl realFlowControl commented Oct 16, 2024

Based on @arnaud-lb's comment I decided to revert the refcounts for array. This is not in line with the rest that happens there, but it makes develop stable again. Once I do fully understand what is going on, I'll cleanup things

@realFlowControl
Copy link
Collaborator Author

realFlowControl commented Oct 16, 2024

@arnaud-lb: I know from your comment, that this is not a viable solution and works against what the code in src/copy.c is doing, but if it fixes the problem at hand (and it does), I'm willing to take it. Could you do me a favour and do a review?

This was referenced Oct 16, 2024
Open
Closed
@realFlowControl
Copy link
Collaborator Author

realFlowControl commented Oct 16, 2024

Hmm, this makes #316 segfaulting, while on develop branch #316 is stable although giving you a zend_mm_heap corrupted at the end of the execution.

@cmb69
Copy link
Collaborator

cmb69 commented Oct 16, 2024

although giving you a zend_mm_heap corrupted at the end of the execution.

Can you check that with ASan? zend_mm_heap corrupted might hint at a use-after-free.

@realFlowControl
Copy link
Collaborator Author

realFlowControl commented Oct 16, 2024

So, having a look again at the entire thing: I does not change anything for #316. #316 segfaults with OPcache and gets a zend_mm_heap corrupted without OPcache on develop and on this PR

arnaud-lb
arnaud-lb reviewed Oct 16, 2024
View reviewed changes
Copy link

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

#316 seems unrelated. From what I can see, a map_ptr is allocated when opcache is not locked, which causes corruptions.

@realFlowControl realFlowControl merged commit 002f3d5 into develop Oct 17, 2024
@realFlowControl realFlowControl deleted the florian/fix-array-stuff branch October 17, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arnaud-lb arnaud-lb arnaud-lb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@realFlowControl @cmb69 @arnaud-lb