Fix memory leak in nested closure handling #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroonza
approved these changes
Jul 23, 2025
jkroonza
left a comment
There was a problem hiding this comment.
Looks good, can confirm this fixes the problem we're seeing!
jkroonza
added a commit
to jkroonza/gentoo
that referenced
this pull request
Jul 23, 2025
See also: krakjoe/parallel#345 krakjoe/parallel#347 Closes: https://bugs.gentoo.org/957101 Signed-off-by: Jaco Kroon <[email protected]>
jkroonza
added a commit
to jkroonza/gentoo
that referenced
this pull request
Jul 23, 2025
See also: krakjoe/parallel#345 krakjoe/parallel#347 Closes: https://bugs.gentoo.org/957101 Signed-off-by: Jaco Kroon <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 23, 2025
See also: krakjoe/parallel#345 krakjoe/parallel#347 Closes: https://bugs.gentoo.org/957101 Signed-off-by: Jaco Kroon <[email protected]> Part-of: #43125 Signed-off-by: Sam James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak that caused the cache to exhaust when running closures with nested functions (dynamic function definitions).
When scheduling closures containing nested functions,
php_parallel_cache_closure()was allocating memory from the cache pool for thedynamic_func_defsarray. This memory was never properly freed, causing the cache to fill up and eventually trigger arealloc()that could lead to segfaults in case the OS decided to move the entire allocation to a different address.fixes #345