Switch Windows CI to php-windows-builder
#362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c10b18e to
876cbca
Compare
bc9d515 to
accd43c
Compare
Collaborator
Author
|
This is blocked on php/php-windows-builder#21 |
Collaborator
Author
|
Fix in php/php-windows-builder#22 |
2b5db8c to
7aaef6a
Compare
7aaef6a to
ee83ee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
php/setup-php-sdkthere where some problems which should be fixed with php/setup-php-sdk#18, but as @cmb69 pointed out, we could just use thephp/php-windows-builderGitHub Action and it turns out, we are already using it to create releases, so I figured: we could just use this one to also run the tests.