Remove safe_mode check in curl client#435
Merged
Merged
Conversation
INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4
We no longer seem to have access to it
At the moment the code gets checked out by a user with the uid 1001 but the nyholm/roave-bc-check-ga runs as root which triggers the fatal: detected dubious ownership in repository at '/github/workspace' error. Running the commands in that container as a user with the user id 1001 is, to my understanding, not possible using default GitHub Actions config so the workaround of using addnab/docker-run-action@v3 is used to allow for defining the user id uding -u 1001 (and setting then not available, GITHUB_REPOSITORY variable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.