fix for empty extension on asset dump#876
Open
webbird wants to merge 9 commits into
Open
Conversation
avoid empty extension if inner asset is something like => http://fonts.googleapis.com/css?family=Abel
fix for empty extension
# fixed missing bracket in AssetFactory.php # some fixes in CATCssRewriteFilter.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had problems with inner assets like
=> http://fonts.googleapis.com/css?family=Abel
Result was an empty file extension, as the $extensions array had 2 keys.
0 => 'css', 1 => ''