Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Missing version number in mac binaries #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suschizu opened this issue Aug 3, 2020 · 14 comments
Closed

Missing version number in mac binaries #401

suschizu opened this issue Aug 3, 2020 · 14 comments
Assignees

Comments

@suschizu
Copy link

suschizu commented Aug 3, 2020

The latest mac download doesn't contain a version number:

Screen Shot 2020-08-03 at 23 03 19

@DamirPorobic
Copy link
Member

Thanks for reporting. Is this happening with the continuous built too? You downloaded the dmg file from GitHub?

@suschizu
Copy link
Author

suschizu commented Aug 3, 2020

hey @DamirPorobic - I've downloaded the latest macos release from the GitHub project - the continuous build doesn't contain a mac build

@DamirPorobic
Copy link
Member

It should be there in couple of minutes but the result is going to be the same. I'll have a look into it.
One more question maybe, was the version tag there written in previous ksnip versions?

@suschizu
Copy link
Author

suschizu commented Aug 3, 2020

I've just checked versions 1.5.0 / 1.6.1 / 1.7.1 and 1.7.2 - version number is always missing - I've noticed it because the app has a homebrew cask now (https://github.com/Homebrew/homebrew-cask/blob/master/Casks/ksnip.rb) and the downloaded file had an empty version string

@DamirPorobic
Copy link
Member

Ok, I'll check how to fix that.

@DamirPorobic
Copy link
Member

@suschizu can you check if this is fixed in the latest continuous build version from here https://github.com/ksnip/ksnip/releases/tag/continuous?

@suschizu
Copy link
Author

hey @DamirPorobic - no sorry - the issue isn't resolved - the info.plist is still missing the BundleVersion and ShortVersionString key

	<key>CFBundleShortVersionString</key>
	<string></string>
…
	<key>CFBundleVersion</key>
	<string></string>

image

@DamirPorobic
Copy link
Member

Sorry I need to clarify this again, do you use the dmg from github directly to install ksnip or do you get it through the Brew Cask?

@DamirPorobic DamirPorobic self-assigned this Dec 22, 2020
@DamirPorobic
Copy link
Member

DamirPorobic commented Dec 22, 2020

I have added some additional version string variables, let's see if they change something. The CI is currently unusually slow, it might take up to 2 hours till my latest changes are available. Would be nice if you could later this afternoon check again if you see any version string and if yes, which one. @suschizu

@suschizu
Copy link
Author

suschizu commented Dec 22, 2020

Sorry I need to clarify this again, do you use the dmg from github directly to install ksnip or do you get it through the Brew Cask?

hey @DamirPorobic - I used the github download (but brew cask uses the same download url)

not sure if this will help:
https://doc.qt.io/archives/qt-4.8/mac-differences.html

@DamirPorobic
Copy link
Member

@suschizu thanks. We set those variables via CMAKE before we build, Qt uses only the result. I have found three other variables that could be used to define the version and I have the suspicion that the variable from where we read the version was not set. The new dmg package should be finished in couple of minutes, let's see if anything is in there.

@DamirPorobic
Copy link
Member

@suschizu give it a try now.

@suschizu
Copy link
Author

hey @DamirPorobic - here we go 👍
Screen Shot 2020-12-22 at 15 07 42
thanks for your patience :)

the info.plist looks good too now:

<dict>
	<key>CFBundleDevelopmentRegion</key>
	<string>English</string>
	<key>CFBundleExecutable</key>
	<string>ksnip</string>
	<key>CFBundleGetInfoString</key>
	<string>Cross-Platform Screenshot and Annotation Tool</string>
	<key>CFBundleIconFile</key>
	<string>ksnip.icns</string>
	<key>CFBundleIdentifier</key>
	<string>org.ksnip.ksnip</string>
	<key>CFBundleInfoDictionaryVersion</key>
	<string>6.0</string>
	<key>CFBundleLongVersionString</key>
	<string>1.8.1b</string>
	<key>CFBundleName</key>
	<string></string>
	<key>CFBundlePackageType</key>
	<string>APPL</string>
	<key>CFBundleShortVersionString</key>
	<string>1.8.1a</string>
	<key>CFBundleSignature</key>
	<string>????</string>
	<key>CFBundleVersion</key>
	<string>1.8.1c</string>
	<key>CSResourcesFileMapped</key>
	<true/>
	<key>NSHumanReadableCopyright</key>
	<string></string>
</dict>

@DamirPorobic
Copy link
Member

Great, now I know where the issue might be. Those are currently only hard coded strings, will make it dynamic again tonight.

Thanks for testing!

@DamirPorobic DamirPorobic changed the title Missing version number in 1.7.3 mac download Missing version number in mac binaries Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants