-
-
Notifications
You must be signed in to change notification settings - Fork 198
Missing version number in mac binaries #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting. Is this happening with the continuous built too? You downloaded the dmg file from GitHub? |
hey @DamirPorobic - I've downloaded the latest macos release from the GitHub project - the continuous build doesn't contain a mac build |
It should be there in couple of minutes but the result is going to be the same. I'll have a look into it. |
I've just checked versions 1.5.0 / 1.6.1 / 1.7.1 and 1.7.2 - version number is always missing - I've noticed it because the app has a homebrew cask now (https://github.com/Homebrew/homebrew-cask/blob/master/Casks/ksnip.rb) and the downloaded file had an empty version string |
Ok, I'll check how to fix that. |
@suschizu can you check if this is fixed in the latest continuous build version from here https://github.com/ksnip/ksnip/releases/tag/continuous? |
hey @DamirPorobic - no sorry - the issue isn't resolved - the info.plist is still missing the BundleVersion and ShortVersionString key
|
Sorry I need to clarify this again, do you use the dmg from github directly to install ksnip or do you get it through the Brew Cask? |
I have added some additional version string variables, let's see if they change something. The CI is currently unusually slow, it might take up to 2 hours till my latest changes are available. Would be nice if you could later this afternoon check again if you see any version string and if yes, which one. @suschizu |
hey @DamirPorobic - I used the github download (but brew cask uses the same download url) not sure if this will help: |
@suschizu thanks. We set those variables via CMAKE before we build, Qt uses only the result. I have found three other variables that could be used to define the version and I have the suspicion that the variable from where we read the version was not set. The new dmg package should be finished in couple of minutes, let's see if anything is in there. |
@suschizu give it a try now. |
hey @DamirPorobic - here we go 👍 the info.plist looks good too now:
|
Great, now I know where the issue might be. Those are currently only hard coded strings, will make it dynamic again tonight. Thanks for testing! |
The latest mac download doesn't contain a version number:
The text was updated successfully, but these errors were encountered: