Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Show magnifying glass on snipping area resizer #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MurzNN opened this issue Nov 16, 2020 · 6 comments
Open

Show magnifying glass on snipping area resizer #472

MurzNN opened this issue Nov 16, 2020 · 6 comments

Comments

@MurzNN
Copy link
Contributor

MurzNN commented Nov 16, 2020

At now when we press CTRL to enable resize capture area mode, implemented in #197, the magnify tool is disappearing. Will be good to keep them, for exact tuning of captured area edges.

Also resize area widget now shows the red circles, that cover captured area at edges, and captured pixels on edges becomes invisible. Will be good to cut-out inside area of the circles to show the whole captured area. Is it hard to implement?

@DamirPorobic DamirPorobic self-assigned this Nov 16, 2020
@DamirPorobic
Copy link
Member

When does the magnifying tool disappear? I can't reproduce that on my side, the magnifying glass is always there.

Regarding the circles, it looks strange when the circles are cut out, that was the first version. How about hiding the circles while resizing (when you click on one circle)?

@MurzNN
Copy link
Contributor Author

MurzNN commented Nov 16, 2020

magnifying glass is disappearing for me after I un-press mouse button (after holding CTRL) and widget to resize are is shown (with red border and circles), so it didn't help me when resizing area to exact pixel.
P. S. How can I make a screenshot of screenshot making interface? :)

@MurzNN
Copy link
Contributor Author

MurzNN commented Nov 16, 2020

About circles - maybe replace them to lines outside of area (half of crosshairs), something like typography crop marks?
image
image

@DamirPorobic
Copy link
Member

Now I get you. The Magnifying glass is not missing, it just was not added in the resizer. We can handle this as a new feature request.

What would be the handle with those cropmarks? Also, it kind of is a standard to have a circle or rect as handle, people are used to it. For now I will just make them hidden when you grab one. For more advanced stuff please log a separate issue.

@DamirPorobic DamirPorobic changed the title Keep magnify tool in resize capture area mode and do not cover captured area Show magnifying glass on snipping area resizer Nov 16, 2020
@DamirPorobic DamirPorobic removed their assignment Nov 16, 2020
@MurzNN
Copy link
Contributor Author

MurzNN commented Nov 16, 2020

The problem with circles is that they hide the part of corners in snipping area, but they are important for exact fit the area to needed rectangle, for example - to snip rounded corners with radius 3-5 pixel.
If we keep the circles, will be good to see something like this:
image

@DamirPorobic
Copy link
Member

There you go, implemented exactly that behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants