Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow modifying selected rectangle before making screenshot #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MurzNN opened this issue Aug 19, 2019 · 15 comments
Closed

Allow modifying selected rectangle before making screenshot #197

MurzNN opened this issue Aug 19, 2019 · 15 comments

Comments

@MurzNN
Copy link
Contributor

MurzNN commented Aug 19, 2019

At now after mouse up event after drawing rectange, ksnip immediately make screenshot. But very often users want to modify size of drawn rectangle manually - move, change size.

Most other screenshot tools (eg Spectacle) have this mode enabled by default. Can you please implement option for enable this feature after drawing screenshot in ksnap too? Thanks!

@DamirPorobic
Copy link
Member

Might be a larger feature but doable.

@vitiok78
Copy link

Most of the time I don't need this feature, so this extra-step will be more harmful than useful in my workflow. So this must be an option to choose.

@DamirPorobic
Copy link
Member

Same here, I'm not a big fan of the workflow like in KDE Spectacle but I believe there are people that are used to it. As always, when we do it then it will be configurable.

@pn2
Copy link

pn2 commented Sep 8, 2020

I also miss the option to adjust the rectangle to be captured. For example, when using a graphics tablet or another pen-like input device, I sometimes reach the edge and need to "re-grab", which currently is not possible. Also, with pens "clicking" precisely is more difficult than with a mouse.

Update: I just realized that a work-around is to grab the screen with an application that allows for this rectangle adjustment, and then simply paste the clipboard content into ksnip.

@DamirPorobic
Copy link
Member

I'll try to implement this with the next release.

@MurzNN
Copy link
Contributor Author

MurzNN commented Sep 9, 2020

Meanwhile KDE Spectacle adds your kImageAnnotator library to himself: https://phabricator.kde.org/D22074 - congratulations for improving popularity of your libKImageAnnotator!

@DamirPorobic
Copy link
Member

Thanks :)

@derei
Copy link

derei commented Oct 6, 2020

I agree that it should be as an option, rather than switching from current functionality. The current way is fast and handy, but less accurate. Is great for quick snaps, but sometimes it just requires the added precision.

Thank you for considering it.

@DamirPorobic
Copy link
Member

I have in mind a config option where you select one of those two options as default and you use that. Later, we could add a toggle (I don't know, maybe holding down CTRL key or something) that can be pressed while snipping (and before releasing) to switch from default mode to the other.

@derei
Copy link

derei commented Oct 6, 2020

You could just add a new option in the drop-down list.

  • Rectangular Area (quick)
  • Rectangular Area (precise)
    The first one would behave as now, whilst the second should enable a snapshot button in the bar, along with the handles. For taking the screenshot, one would have to press the button.

@DamirPorobic
Copy link
Member

Thanks, I'll keep it in mind, haven't decided yet which way to go.

@MurzNN
Copy link
Contributor Author

MurzNN commented Oct 6, 2020

Later, we could add a toggle (I don't know, maybe holding down CTRL key or something) that can be pressed while snipping (and before releasing) to switch from default mode to the other.

This is cool idea for implementation! It can be implemented via some visible hint like "Press CTRL for enable manual area resize mode after selecting." on screen.

@DamirPorobic
Copy link
Member

It can be implemented via some visible hint like "Press CTRL for enable manual area resize mode after selecting." on screen.

Exactly what I had in mind. But we can think about it later, I would handle it in a separate issue. How yuo will need to pick a default in settings (when the feature is implemented of course).

@DamirPorobic DamirPorobic self-assigned this Nov 9, 2020
@DamirPorobic DamirPorobic changed the title Add mode for manual modify size of drawn rectange before making screenshot Allow modifying size of drawn rectangle before making screenshot Nov 10, 2020
@DamirPorobic DamirPorobic changed the title Allow modifying size of drawn rectangle before making screenshot Allow modifying size of selected rectangle before making screenshot Nov 10, 2020
DamirPorobic added a commit that referenced this issue Nov 10, 2020
DamirPorobic added a commit that referenced this issue Nov 10, 2020
DamirPorobic added a commit that referenced this issue Nov 10, 2020
@DamirPorobic
Copy link
Member

There you go, you can enable this feature here
image

By default it's disabled.

@DamirPorobic DamirPorobic changed the title Allow modifying size of selected rectangle before making screenshot Allow modifying selected rectangle before making screenshot Nov 15, 2020
@DamirPorobic
Copy link
Member

This is now implemented with a switch to change from one behavior to the other while drawing the selection rectangle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants