-
-
Notifications
You must be signed in to change notification settings - Fork 198
Close button hidden after taking screenshot under kwin #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That part of the window is not ksnip responsibility, it should be window manager responsibility. I believe I have seen this on other windows, for me it occurs often for CLion windows when started and I thought it was some strange KDE usability thing. Can you please check with KDE if that issue was reported there already? |
I'll try to talk to some KDE developer. Sorry for bugging your software |
Hello, Sorry to comment on a closed issue, but I have doubts about a kwin bug. I have observed this behavior: I make ksnip appear by double clicking on the systray icon. I had this kind of problem before with Rider and it was not a problem with kwin but directly in Rider. Maximizing Rider's window made the close icon disappear. |
Hey Benjamin, no need to be sorry, I'll open the bug again if there is something we can do. I'm still not convinced that this is not a kwin issue because:
Anyways, my whining around doesn't help us here. Do you have the kwin issue that was logged for this? Maybe we can find a workaround. |
Hi @DamirPorobic before opening an issue i asked the question in the reddit kde sub. I await a response from them. |
I think I found what is triggering this issue, it's a workaround for Qt that allows us to return to the initial minimal size after for example closing all tabs. We set temporarily a fixed size, resize, then revert back to adjustable size:
Removing the first line fixes the issue. I think the problem comes from the first line changing the available buttons on the title bar, with fixed size you probably have only two, minimize and close but not maximize because the size if fixed. Then we adjust the size, the frame size is calculated together with the position for the buttons which is probably frame width minus size of two buttons, that's where kwin starts drawing the buttons. Next, we make the window resizeable again, now we have three buttons again, the maximize button comes between the minimize and close button but kwin doesn't recalculate the starting position for the buttons and tries to squeeze three buttons where are only two supposed to be. IMHO kwin should recalculate the button position whenever the button count changes. |
Yes, that would make sense. Maybe we should open an issue on bugs.kde.org to find out if there is another way to do it. |
I have logged a KDE issue for this https://bugs.kde.org/show_bug.cgi?id=434620 I'm also linking your reddit post here for reference https://www.reddit.com/r/kde/comments/m8c88r/no_titlebar_close_button_on_ksnip_after_capture/grguguy/?newUser=true I have also tried some workarounds to fix this behavior but non seem to work unfortunately. Let's see what the KDE guys say. |
Nice. We just have to wait :) |
Ok, maybe I did found an improvement. On my KDE Plasma the close button is visible after taking screenshots and hidden only after closing all tabs. Not perfect but better then what we had earlier. Can you test if you see an improvement, just give the CI some time to build the packages. |
I'm testing this on Monday :) |
what version of plasma and kwin are you using? |
Me, I use kde neon. This use latest version of kde plasme, qt framework, etc... |
I have the button as described above. |
Ok, I'm going to close this issue as I don't expected any feedback soon from the KDE guys. When somethings happens later on I'll take care of it. |
This is a rather strange bug that I initially thought about reporting on bugs.kde.org, but ksnip is the only application where this is happening.
The bug looks like this
Screenshot
Video
simplescreenrecorder2-2021-02-20_13.06.35.mp4
This does not happen when ksnip is opened directly (without taking a screenshot).
And if the window is resized to a larger size, the button is shown.
The text was updated successfully, but these errors were encountered: