-
-
Notifications
You must be signed in to change notification settings - Fork 198
HiDPI scaling not handled correctly under windows #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Interesting, you're having this issue with Windows. Dual monitor or single monitor? |
I've read about this issue with dual monitor in Linux. |
addition: with scaling 100% and reboot, I don't have the issue |
Sorry I didn't get if you have Notebook + Monitor or just Notebook? |
Just notebook. |
Hi, I have exactly the same problem, but with 1920 x 1080 laptop screen with 150% scaling. Windows 10 Enterprise (version 2004, build 19041.804) |
@eff-sunny thanks for reporting, I'll try to reproduce. |
I have this problem too, on ubuntu 20.10, with snap and app image, 1.8.1 and "1.9.0". If ksnip launches on my primary monitor (which it always does), it assumes it is in hidpi mode, and when I move any part of the application window to a second monitor, it becomes tiny. My primary monitor is 4K, but not hidpi. My other monitors are also not hidpi, but a more normal resolution (they are both 1920x1200). Also, when doing a rectangular area screenshot, it is effectively unusable. It is hard to describe: I seem to see all monitors shrunk so much that I can't see what I am selecting. |
I installed from flatpak. Then the session crashed, so I logged out and in again, and it works much better. The appimage and snap were also badly themed, but the flatpak version looks much better. It also works properly. |
@timrichardson I don't think that you have the same issue, sounds different then what @eff-sunny has. His issue is hdpi related and single monitor. You have dual monitors without hidpi. I think I would look a new issue for that. |
I have a hidpi issue: the app thinks my 4K screen is hidpi, and everything goes badly after that., because it is just wrong about that. The zoom client does it too (a qt bug), but in zoom, there is a setting to turn "auto hidpi detection" off. However, I will file a new issue. |
@mjverbeek what Linux Distro and Desktop Manager are you using? |
Not Linux, I'm on Windows 20H2 19042.867 |
Oh, sorry, my wrong. Thanks for clarifying. |
Ok, I can reproduce this issue. It seems to be a regression introduced after releasing |
@mjverbeek @eff-sunny I have pushed a change that should fix this issue. Can you test if it's working for you now? Just give the CI a couple of minutes to finish. |
I will check this fix. But where can I find it? And what is CI? |
All good, you can find it here https://github.com/ksnip/ksnip/releases/tag/continuous The CI is the server that builds those packages and uploads them to that page. Any window build that you see from now on there should already contain the fix. |
Was this before like that or is it something new introduced with my change? |
Oh, and is it pixelated only on the saved image or in the annotator already? |
As far as I know this was introduced with this change. I saw it in the editor and saved it to check if it was there too. And it did, so both in editor and saved file are pixelated. |
I stopped ksnip, deleted HKCU/SOFTWARE/ksnip, started ksnip and now the pixelation is gone. |
AutoCopyToClipboardNewCaptures = true will pixelate |
Yes, you're right I can reproduce it. I'll log for that another issue and close this one. |
I'm seeing this on my 4K laptop monitor using ksnip 1.8.1 build 1686.d6b138b
3840 x 2160 225% scaling.
I've seen this behaviour before, in prior versions.
Just wanted to share.
This is what I see on my monitor:
As soon as I start 'take screenshot' with ksnip screen is aprox 1/4 of the monitor: (1/225% ?)
This is the area I select for screenshot:
And this is the result:
The text was updated successfully, but these errors were encountered: