-
-
Notifications
You must be signed in to change notification settings - Fork 198
Preview of screenshot is scaled after changing desktop size #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, there were some changes in this area. Can you double check if it's happening also with the latest continuous build? |
Pushed a fix, can you check if it fixes your issue? The pepile needs a couple of minutes to build. |
Version: 1.10.0-continuous Doesn't seem to have made any difference, unfortunately. |
Pushed a new fix, can you please test again? |
I'm using the AUR git version, after update and reboot, changing screens still result in this.
Edit: In this case, I had only 1 monitor, enabled the second one and did the screenshot |
@Sqbika I'm a bit confused by this version there |
The application reports 1.9.2 whenever invoked with |
Yeah, the |
Okay, that was a very amateur oversight from me. And old ksnip version was lingering in |
Awesome! Let's wait for OP's feedback before closing this issue then. |
Well that's interesting. I just tried |
That is then indeed interesting, I was able to reproduce it. The commit hash there seems correct, it's from the About dialog? |
After double checking, the toggling of displays works, but changing the display resolution does not do the recalculation |
Yes, this was about changing monitor count, didn't take into just switching resolution. |
Resolution change doesn't require logging out (I'm using ARandR for changing resolution), scaling requires logout on KDE |
Ok, I'll have a look into it tonight to cover that case too. |
Next round, give it a try again, the resolution change use case should be covered now. |
I hadn't realised that there would be a subtle difference between switching monitors + dimensions and just switching dimensions, so my bug report and subsequent testing didn't account for this [in other words, I can't recall exactly which way I was testing this at any previous point]. |
Appimage isn't any different. |
For the ksnip-git package, the detections works for both resolution, orientation and toggling monitors |
@troffasky How many monitors do you have? Any screen scaling? What is the monitor setup (left right, bottom, top)? Where do you change the resolution, on one, (left, right) or both? |
Laptop + monitor. The monitor is 4K but the laptop cannot drive both the monitor and the builtin display simultaneously at higher resolutions, so I am only ever using one at a time.
"Global scale" is set to 100% so I guess that means there is no scaling. |
So basically you have a single monitor on which you change the resolution? Haven't tried that I think, I always changed it on my secondary. I'll try to reproduce later. |
I've tested with version 1.10.0-continuous (build: 1-626c2c8) and this issue is fixed, thanks! |
Sorry I didn't update this earlier, yes this is fixed for me. |
Describe the bug
The frozen preview of the screen is scaled, if the desktop dimensions have changed since starting ksnip. If you select the "right" area, it will capture it correctly, but you have to guess as you won't snip what it looks like you will snip
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The frozen preview should not be scaled.
Desktop (please complete the following information):
Additional context
I am pretty sure this issue appeared after upgrading from 1.9.1 to 1.9.2
The text was updated successfully, but these errors were encountered: