Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

fnkabit
Copy link
Contributor

@fnkabit fnkabit commented Nov 5, 2020

Feature #386

Copy link
Member

@DamirPorobic DamirPorobic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just thinking if this settings is an application setting or belongs to the image grabber, which is settings related to taking screenshot. What do you think?

@DamirPorobic DamirPorobic self-assigned this Nov 5, 2020
@DamirPorobic DamirPorobic linked an issue Nov 5, 2020 that may be closed by this pull request
@fnkabit
Copy link
Contributor Author

fnkabit commented Nov 6, 2020

Looks good. Just thinking if this settings is an application setting or belongs to the image grabber, which is settings related to taking screenshot. What do you think?

Yes, I think you are right, it would be better to place it in the 'Image Grabber' section.

@DamirPorobic
Copy link
Member

DamirPorobic commented Nov 8, 2020

Looking good! Thanks for implementing this feature!

@DamirPorobic DamirPorobic merged commit e364f6c into ksnip:master Nov 8, 2020
@fnkabit
Copy link
Contributor Author

fnkabit commented Nov 8, 2020

Looking good! Thanks for implementing this feature!

Glad it works. Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make hiding main window during screenshot optional
2 participants