Add missing includes to build on UNIX #581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Rafael, I'll bring this change into a hotfix |
|
The underlying problem (hi Rafael, good to see the BSD folks hitting all the same updates) is that ScaledSizeProvider.h uses |
|
Ideally, picking up this patch, and removing the corresponding includes from ScaledSizeProvider.h would save compilation time (for consumers of the header) and fix the build on the BSDs. |
|
Thanks for providing the PR, I have cherry-picked it into the next patch branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply add the missing includes to unbreak the build