ci: deb: Also install kimageannotator translation #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let CI-built ksnip conflicts with libkimageannotator-common. CI-built deb package provides kimageannotator translation files, which are supposed to be provided by libkimageannotator-common in Debian official packages. The additional conflicts relationship prevents file conflicts from happening. NOTE: this means you will not longer able to install CI-built ksnip and distribution-provided KDE spectacle together, because kde-spectacle depends on distribution-provided libkimageannotator libraries and translations.
|
Sounds problematic, basically you cannot install the ci deb package on KDE Plasma as spectacle is always installed there, or? Do we have any workaround? Maybe installing the translation files in the same directory as ksnip translations? |
|
As long as translation files are provided separately, file conflict is inevitable. Even if files are installed elsewhere, you need to make (the embedded) libkimageannotator smart enough to pick up translation elsewhere. |
|
Thanks for providing this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request closes: #359 .
NOTE: This Pull Request comes with inevitable side effects! Merge with caution.
CI-built ksnip package now additionally conflicts with libkimageannotator-common.
CI-built deb package provides kimageannotator translation files, which are supposed to be provided by libkimageannotator-common in Debian official packages. The additional conflicts relationship prevents file conflicts from happening.
This means users will not longer able to install CI-built ksnip deb package and distribution-provided KDE spectacle (KDE's default screenshot tool) together, because kde-spectacle depends on distribution-provided libkimageannotator libraries and translations.