Implement save all feature #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you think this would be useful, it could be extended for when closing ksnip with unsaved tabs; displaying a "Save All" button, alongside the "Yes", "No" and "Cancel" buttons. |
DamirPorobic
requested changes
Jan 7, 2022
|
@fnkhz just a minor change and missing test. If you are busy I can do the change and tests too. |
|
@DamirPorobic Thanks for the review! Updated PR; if there is something missing please let me know. |
DamirPorobic
approved these changes
Jan 8, 2022
|
Looking good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #754