Experiment with multi_reflectors #1687
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the question has showed up a few times. ultimately this is awkward because the hard generic use in ObjectRef<K> and in Store<K> which ties them to a particular resource. It feels like it shouldn't have to be this way because the Store::get takes an ObjectRef, which feels dynamically typed, but actually isnt. Tried out a couple of potentials and had to just resort to the dumb thing instead. Maybe there's some other things we can do for dynamics. Maybe worth exploring in an issue? Signed-off-by: clux <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1687 +/- ##
=====================================
Coverage 75.8% 75.8%
=====================================
Files 84 84
Lines 7630 7630
=====================================
Hits 5779 5779
Misses 1851 1851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the question has showed up a few times.
ultimately this is awkward because the hard generic use in ObjectRef and in Store which ties them to a particular resource.
It feels like it shouldn't have to be this way because the Store::get takes an ObjectRef, which feels dynamically typed, but actually isnt.
Tried out a couple of potentials and had to just resort to the dumb thing instead.
Maybe there's some other things we can do for dynamics. Maybe worth exploring in an issue?