Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Tracker() function to fake dynamic client #100085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

Add Tracker() function to fake dynamic client #100085

merged 1 commit into from
Apr 9, 2021

Conversation

markusthoemmes
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This adds a Tracker() function to the fake dynamic client to make this "interface" even with all of the other fake clients that allow access to the underlying tracker. This is useful to define external Watch reactors.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

DynamicFakeClient now exposes its tracker via a `Tracker()` function

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @markusthoemmes. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 10, 2021
@k8s-ci-robot k8s-ci-robot requested review from sttts and yliaog March 10, 2021 13:21
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2021
@yliaog
Copy link
Contributor

yliaog commented Mar 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2021
@markusthoemmes
Copy link
Contributor Author

/assign @liggitt

@yliaog
Copy link
Contributor

yliaog commented Mar 11, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@liggitt
Copy link
Member

liggitt commented Mar 11, 2021

is there an actual interface somewhere this should type-assert to make sure it doesn't drift?

@caesarxuchao
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 11, 2021
@markusthoemmes
Copy link
Contributor Author

@liggitt not that I am aware of, I suppose we could create an interface for fake clients that also requires the Reactor related functions?

@markusthoemmes
Copy link
Contributor Author

@liggitt think we should block this in the absence of such an Interface? I'm happy to go add it to the machinery, just let me know if you want the interface before or after this change.

@liggitt
Copy link
Member

liggitt commented Mar 15, 2021

/approve

Doesn't need to block, but if this is being checked in a type assertion somewhere, there should probably be an interface to go along with it

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@markusthoemmes
Copy link
Contributor Author

I'll make sure to followup! Thanks!

@markusthoemmes
Copy link
Contributor Author

Do I need to poke anybody to fix the milestone thingy @liggitt?

@liggitt
Copy link
Member

liggitt commented Mar 17, 2021

Do I need to poke anybody to fix the milestone thingy @liggitt?

1.21 is in code freeze, this will merge once master reopens for 1.22

@markusthoemmes
Copy link
Contributor Author

Gotcha, thanks!

@k8s-ci-robot k8s-ci-robot merged commit c6e826a into kubernetes:master Apr 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 9, 2021
@markusthoemmes markusthoemmes mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@liggitt liggitt

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@markusthoemmes @k8s-ci-robot @yliaog @liggitt @caesarxuchao