Fix of reverted #9728 #10057
Fix of reverted #9728 #10057
Conversation
This will allow us to use a nodeName that is not the hostname, for example on clouds where the hostname is not the natural identifier for a node.
The EC2 instance id is the canonical node name on EC2.
When we build a Kubelet directly we need to populate NodeName as well as hostname, because we bypass the functions that normally do this for us.
|
LGTM |
|
GCE e2e build/test passed for commit 27b02d0. |
|
@justinsb My question is that why shippable didn't complain at the first place. But I do think your fix added here fix the test issue. |
|
@dchen1107 I don't know (and I'm just confusing myself: #9728 (comment)) I did figure out that e2e testing tests not the result of the merge, but rather the tree at the head of the PR branch. We should probably make sure shippable is testing the merge result, although the downside is that requires re-running on every merge, which is expensive. But in any case, I don't think these are new unit tests, so I don't know. I'm also worried that my tests didn't pick this up either. I run e2e tests, which require building a release, which require running the tests. I am very confused. |
|
I ran the unit tests for this PR and they pass. |
Not sure if we still want to merge this, but this is #9728 with the fix for the unit test; will hopefully pass shippable and e2e.
I needed to directly initialize NodeName in the unit tests where we directly build a Kubelet. I need to figure out how this got past my testing.