Thanks to visit codestin.com
Credit goes to github.com

Skip to content

List pod list once to avoid timeout in Multi-AZ Clusters #100762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2021
Merged

List pod list once to avoid timeout in Multi-AZ Clusters #100762

merged 1 commit into from
Apr 11, 2021

Conversation

AliceZhang2016
Copy link
Contributor

What type of PR is this?

/kind bug
/sig scheduling

What this PR does / why we need it:

In current computeCPUMemFraction function, it list all pods in cluster for each node to check if this pod is scheduled on the node. When there are lots of nodes and pods, it lead to timeout.
Therefore, we only list pods once, and stores the information that which pods are on the associated node.

Which issue(s) this PR fixes:

Fixes #100705

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

@AliceZhang2016: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @AliceZhang2016. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 1, 2021
@alculquicondor
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2021
alculquicondor
alculquicondor reviewed Apr 1, 2021
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, AliceZhang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2021
@alculquicondor
Copy link
Member

cc @mborsz

Huang-Wei
Huang-Wei reviewed Apr 2, 2021
View reviewed changes
@adtac
Copy link

adtac commented Apr 6, 2021 •
edited
Loading

LGTM apart from @Huang-Wei's review comments. Do we know if this was the root cause (did this patch solve the timeout)?

@AliceZhang2016
Copy link
Contributor Author

/retest

@Huang-Wei
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2021
@alculquicondor
Copy link
Member

@ahg-g can we set the milestone for this one?

@ahg-g
Copy link
Member

ahg-g commented Apr 6, 2021 •
edited
Loading

I think the branch is closed, this needs to be cherry picked If we want it in 1.21.

mborsz
mborsz reviewed Apr 7, 2021
View reviewed changes
test/e2e/scheduling/priorities.go
totalRequestedCPUResource += getNonZeroRequests(&pod).MilliCPU
totalRequestedMemResource += getNonZeroRequests(&pod).Memory
for _, pod := range allPods.Items {
nodeName := pod.Spec.NodeName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if a given pod isn't scheduled yet?

Shouldn't we handle the case when pod.Spec.NodeName is empty, explicitly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already effectively ignoring them when iterating the nodes.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

8 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit dbf1102 into kubernetes:master Apr 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 11, 2021
@alculquicondor
Copy link
Member

@AliceZhang2016

Can you cherrypick to 1.21, 1.20 and 1.19? https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#initiate-a-cherry-pick

This was referenced Apr 12, 2021
Merged
Closed
Merged
Merged
@AliceZhang2016
Copy link
Contributor Author

@alculquicondor
Here are three cherrypick PRs:
#101031
#101038
#101040

k8s-ci-robot added a commit that referenced this pull request Apr 19, 2021
@k8s-ci-robot
Merge pull request #101040 from AliceZhang2016/automated-cherry-pick-…
c8ca35d 
…of-#100762-upstream-release-1.19

Automated cherry pick of #100762: list pod list once to avoid timeout
k8s-ci-robot added a commit that referenced this pull request Apr 19, 2021
@k8s-ci-robot
Merge pull request #101031 from AliceZhang2016/automated-cherry-pick-…
9c33548 
…of-#100762-upstream-release-1.21

Automated cherry pick of #100762: list pod list once to avoid timeout
k8s-ci-robot added a commit that referenced this pull request Apr 19, 2021
@k8s-ci-robot
Merge pull request #101038 from AliceZhang2016/automated-cherry-pick-…
75fcfc3 
…of-#100762-upstream-release-1.20

Automated cherry pick of #100762: list pod list once to avoid timeout
@ingvagabund ingvagabund mentioned this pull request Sep 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer Awaiting requested review from resouer

3 more reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@mborsz mborsz mborsz left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Regression: Multi-AZ Clusters test timing out in big clusters
8 participants
@AliceZhang2016 @k8s-ci-robot @alculquicondor @adtac @Huang-Wei @ahg-g @fejta-bot @mborsz