Thanks to visit codestin.com
Credit goes to github.com

Skip to content

no support endpointslice in linux userpace mode #100913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

no support endpointslice in linux userpace mode #100913

merged 1 commit into from
Apr 26, 2021

Conversation

JornShen
Copy link
Member

@JornShen JornShen commented Apr 8, 2021

/kind bug

in userpace mode of linux, we have not implement endpointslice resource processing logic.
we need to watch endpoint as before in this mode.

Ref #100880

no support endpointslice in linux userpace mode

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 8, 2021
@k8s-ci-robot
Copy link
Contributor

@JornShen: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 8, 2021
@k8s-ci-robot k8s-ci-robot requested review from cmluciano and MrHohn April 8, 2021 08:19
@JornShen
Copy link
Member Author

JornShen commented Apr 8, 2021 •
edited
Loading

/cc @robscott @aojea

I saw the enhancement
https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0752-endpointslices/README.md

And In Motivation, there is words as below.

For a K8s service, if its Endpoints object is too large, endpoint updates will not be propagated to kube-proxy(s), and thus iptables/ipvs won’t be reprogrammed.

EndpointSlice implement only in ipvs mode and iptables mode.
So I think we dont need to implemet userspace. In userspace mode, it will not wirte too much rule to host.
right ?

@k8s-ci-robot k8s-ci-robot requested review from aojea and robscott April 8, 2021 08:30
@aojea
Copy link
Member

aojea commented Apr 8, 2021 •
edited
Loading

/sig network
/assign @danwinship
please, let's hold on it a bit, we were discussing this recently and it didn't come to a conclusion yet
/hold

@danwinship
Copy link
Contributor

If someone volunteered to do this work, we'd review it, but I don't think anyone cares about doing it proactively. The userspace proxy is mostly-deprecated.

@JornShen
Copy link
Member Author

JornShen commented Apr 9, 2021

If someone volunteered to do this work, we'd review it, but I don't think anyone cares about doing it proactively. The userspace proxy is mostly-deprecated.

@danwinship
How about doing like this MR ? Just still watch the endpoints. userspace mode doesn't write much rules to iptables. And I dont think this mode must implement the endpointslice watching.

@aojea
Copy link
Member

aojea commented Apr 9, 2021

/hold cancel
/retest
it lgtm but I defer to Dan last decision

@JornShen
Copy link
Member Author

ping @danwinship

danwinship
danwinship suggested changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@danwinship danwinship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, sorry, I missed that this was a bugfix

@danwinship
Copy link
Contributor

/remove-sig network
/sig network
(trying to fix the "do-not-merge/needs-sig" label)

@k8s-ci-robot k8s-ci-robot removed the sig/network Categorizes an issue or PR as relevant to SIG Network. label Apr 15, 2021
@danwinship
Copy link
Contributor

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 15, 2021
@JornShen JornShen force-pushed the nowatch_endpointslice_in_userspace_Mode branch from c7a7e7b to 4747e2b Compare April 15, 2021 12:18
@JornShen
Copy link
Member Author

/cc @danwinship
PTAL :)

@k8s-ci-robot k8s-ci-robot requested a review from danwinship April 15, 2021 12:19
@aojea
Copy link
Member

aojea commented Apr 17, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2021
@JornShen
Copy link
Member Author

@danwinship
Is the modification ok?

danwinship
danwinship suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@danwinship danwinship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update server_windows.go too?

@JornShen JornShen force-pushed the nowatch_endpointslice_in_userspace_Mode branch from 4747e2b to c842cc5 Compare April 26, 2021 12:33
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2021
@JornShen
Copy link
Member Author

can you update server_windows.go too?

@danwinship
updated. PTAL :)

@danwinship
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, JornShen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit e1ac511 into kubernetes:master Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 26, 2021
This was referenced Apr 27, 2021
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 27, 2021
Open
@danwinship danwinship mentioned this pull request May 3, 2021
Closed
@github-actions github-actions bot mentioned this pull request May 4, 2021
Open
@puerco
Copy link
Member

puerco commented May 4, 2021

@JornShen will you cherry pick this to 1.18?

k8s-ci-robot added a commit that referenced this pull request May 4, 2021
@k8s-ci-robot
Merge pull request #101504 from JornShen/cherry-pick-100913-1.21
cf2e744 
cherry pick of #100913: no watch endpointslice in userpace mode
k8s-ci-robot added a commit that referenced this pull request May 4, 2021
@k8s-ci-robot
Merge pull request #101502 from JornShen/cherry-pick-100913-1.19
c76048f 
cherry pick of #100913: no watch endpointslice in userpace mode
k8s-ci-robot added a commit that referenced this pull request May 4, 2021
@k8s-ci-robot
Merge pull request #101503 from JornShen/cherry-pick-100913-1.20
78bac86 
cherry pick of #100913: no watch endpointslice in userpace mode
@JornShen JornShen mentioned this pull request May 5, 2021
Closed
@JornShen
Copy link
Member Author

JornShen commented May 5, 2021

@puerco thanks for reminding me.
and please see #101741
@danwinship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano Awaiting requested review from cmluciano

@MrHohn MrHohn Awaiting requested review from MrHohn

@aojea aojea Awaiting requested review from aojea

@robscott robscott Awaiting requested review from robscott

1 more reviewer

@danwinship danwinship danwinship requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@danwinship danwinship

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@JornShen @k8s-ci-robot @aojea @danwinship @fejta-bot @puerco