Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Automated cherry pick of #101377: Fix validation in kubectl create ingress #101428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2021
Merged

Automated cherry pick of #101377: Fix validation in kubectl create ingress #101428

merged 2 commits into from
May 6, 2021

Conversation

rikatz
Copy link
Member

@rikatz rikatz commented Apr 23, 2021

Cherry pick of #101377 on release-1.20.

#101377: Fix validation in kubectl create ingress

For details on the cherry pick process, see the cherry pick requests page.

rikatz added 2 commits April 23, 2021 10:47
@rikatz
Fix validation in kubectl create ingress
eeb06c9 
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
@rikatz
Fix validation in kubectl create ingress
f9457bd 
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2021
@rikatz
Copy link
Member Author

rikatz commented Apr 23, 2021

/kind bug
/label tide/merge-method-squash
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 23, 2021
@k8s-ci-robot k8s-ci-robot requested review from dixudx and soltysh April 23, 2021 13:49
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 23, 2021
@rikatz
Copy link
Member Author

rikatz commented Apr 23, 2021

/assign @eddiezane @KnVerey
/cc @eddiezane @KnVerey

@KnVerey
Copy link
Contributor

KnVerey commented Apr 23, 2021

/lgtm
/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2021
@KnVerey
Copy link
Contributor

KnVerey commented Apr 23, 2021

/test pull-kubernetes-e2e-kind

soltysh
soltysh approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@KnVerey KnVerey mentioned this pull request Apr 27, 2021
Merged
@KnVerey
Copy link
Contributor

KnVerey commented Apr 27, 2021

@kubernetes/release-managers this is ready for cherry-pick review. It fixes a panic in kubectl. See also the cherry-pick to 1.21: #101426.

@KnVerey
Copy link
Contributor

KnVerey commented Apr 27, 2021

/test pull-kubernetes-e2e-kind

@rikatz
Copy link
Member Author

rikatz commented Apr 28, 2021

/retest

hasheddan
hasheddan approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, rikatz, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit fe7d806 into kubernetes:release-1.20 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dixudx dixudx Awaiting requested review from dixudx

@eddiezane eddiezane Awaiting requested review from eddiezane

@KnVerey KnVerey Awaiting requested review from KnVerey

+1 more reviewer

@hasheddan hasheddan hasheddan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@eddiezane eddiezane

@KnVerey KnVerey

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
7 participants
@rikatz @KnVerey @k8s-ci-robot @fejta-bot @soltysh @hasheddan @eddiezane