Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GCE Windows: Do not install docker when containerd CRI is selected. #101747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2021
Merged

GCE Windows: Do not install docker when containerd CRI is selected. #101747

merged 1 commit into from
May 5, 2021

Conversation

jeremyje
Copy link
Contributor

@jeremyje jeremyje commented May 5, 2021 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

When containerd is selected as the CRI there should be no dependencies on Docker. We currently use unconditionally install Docker on node boot which is unnecessary. Docker should only be installed when the Docker CRI is selected via kubeenv.

Which issue(s) this PR fixes:

Fixes #101746

Special notes for your reviewer:

Does this PR introduce a user-facing change?

GCE Windows will no longer install Docker on containerd nodes.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 5, 2021
@k8s-ci-robot k8s-ci-robot requested review from mm4tt and pjh May 5, 2021 19:44
@jeremyje
Copy link
Contributor Author

jeremyje commented May 5, 2021

/sig windows
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 5, 2021
@jeremyje
Copy link
Contributor Author

jeremyje commented May 5, 2021

/retest
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2021
@pjh
Copy link
Contributor

pjh commented May 5, 2021

Nit: the release note Docker is no longer installed on containerd nodes should say that this only applies to GCE Windows nodes.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2021
@jeremyje
Copy link
Contributor Author

jeremyje commented May 5, 2021

Manually verified docker is no longer installed..

kubectl get pods -n chatterbox -o wide
NAME                       READY   STATUS    RESTARTS   AGE     IP            NODE                                             NOMINATED NODE   READINESS GATES
chatterbox-linux-24ztq     1/1     Running   0          2m57s   10.64.4.5     e2e-test-jeremyedwards-minion-group-6wmw         <none>           <none>
chatterbox-linux-4fd9f     1/1     Running   0          2m57s   10.64.5.9     e2e-test-jeremyedwards-minion-group-j277         <none>           <none>
chatterbox-windows-4kr7l   1/1     Running   2          2m57s   10.64.2.138   e2e-test-jeremyedwards-windows-node-group-m096   <none>           <none>
chatterbox-windows-qnsl5   1/1     Running   2          2m57s   10.64.3.238   e2e-test-jeremyedwards-windows-node-group-xc18   <none>           <none>
chatterbox-windows-wkhmb   1/1     Running   3          2m57s   10.64.1.43    e2e-test-jeremyedwards-windows-node-group-6gk7   <none>           <none>

kubectl get nodes -o wide
NAME                                             STATUS                     ROLES    AGE     VERSION                              INTERNAL-IP   EXTERNAL-IP      OS-IMAGE                             KERNEL-VERSION    CONTAINER-RUNTIME
e2e-test-jeremyedwards-master                    Ready,SchedulingDisabled   <none>   10m     v1.22.0-alpha.1.160+daa5be1d0162e1   10.40.0.2     35.222.151.248   Container-Optimized OS from Google   5.4.49+           containerd://1.4.1
e2e-test-jeremyedwards-minion-group-6wmw         Ready                      <none>   10m     v1.22.0-alpha.1.160+daa5be1d0162e1   10.40.0.6     104.197.6.137    Container-Optimized OS from Google   5.4.49+           containerd://1.4.1
e2e-test-jeremyedwards-minion-group-j277         Ready                      <none>   10m     v1.22.0-alpha.1.160+daa5be1d0162e1   10.40.0.7     35.238.226.206   Container-Optimized OS from Google   5.4.49+           containerd://1.4.1
e2e-test-jeremyedwards-windows-node-group-6gk7   Ready                      <none>   7m40s   v1.22.0-alpha.1.160+daa5be1d0162e1   10.40.0.3     34.70.110.197    Windows Server 2019 Datacenter       10.0.17763.1879   containerd://1.4.4
e2e-test-jeremyedwards-windows-node-group-m096   Ready                      <none>   7m40s   v1.22.0-alpha.1.160+daa5be1d0162e1   10.40.0.5     35.184.55.57     Windows Server 2019 Datacenter       10.0.17763.1879   containerd://1.4.4
e2e-test-jeremyedwards-windows-node-group-xc18   Ready                      <none>   7m39s   v1.22.0-alpha.1.160+daa5be1d0162e1   10.40.0.4     34.66.198.88     Windows Server 2019 Datacenter       10.0.17763.1879   containerd://1.4.4

docker ps
'docker' is not recognized as an internal or external command,
operable program or batch file.

crictl ps
CONTAINER           IMAGE               CREATED              STATE               NAME                 ATTEMPT             POD ID
c58e8a38a7ed1       5675a08108322       About a minute ago   Running             chatterbox-windows   2                   23b9f39465506

@jeremyje
Copy link
Contributor Author

jeremyje commented May 5, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibabou, jeremyje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a98c559 into kubernetes:master May 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 5, 2021
@jeremyje jeremyje deleted the nodocker branch May 5, 2021 22:13
@github-actions github-actions bot mentioned this pull request May 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt Awaiting requested review from mm4tt

@pjh pjh Awaiting requested review from pjh

1 more reviewer

@ibabou ibabou ibabou approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@pjh pjh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

GCE Windows installs docker for containerd CRI test runs
4 participants
@jeremyje @pjh @k8s-ci-robot @ibabou