Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Automated cherry pick of #101763: Updating EndpointSlice controllers to avoid duplicate #101764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

Automated cherry pick of #101763: Updating EndpointSlice controllers to avoid duplicate #101764

merged 1 commit into from
May 7, 2021

Conversation

aojea
Copy link
Member

@aojea aojea commented May 6, 2021 •
edited
Loading

Cherry pick of #101763 on release-1.19.

#101763: Updating EndpointSlice controllers to avoid duplicate

EndpointSlice controllers are less likely to create duplicate EndpointSlices.

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 6, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 6, 2021
@k8s-ci-robot
Copy link
Contributor

@aojea: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2021
@aojea
Copy link
Member Author

aojea commented May 6, 2021

We've backported a bugfix with a test that exacerbated another bug,
but we didn't backport the fix for the later
#98116
/kind bug
/kind flake
/assign @robscott @swetharepakula

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 6, 2021
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 6, 2021
@robscott
Copy link
Member

robscott commented May 6, 2021

Thanks for cherry picking this @aojea! This LGTM once the build files are fixed.

@aojea aojea force-pushed the automated-cherry-pick-of-#101763-upstream-release-1.19 branch from fa394ec to e88e31c Compare May 6, 2021 17:16
@robscott @swetharepakula @aojea
Updating EndpointSlice controllers to avoid duplicate creations
7b3b4fb 
This updates the StaleSlices() method in EndpointSliceTracker to also
ensure that the tracker does not have more slices than have been
provided.

Co-Authored-By: Swetha Repakula <[email protected]>
@aojea aojea force-pushed the automated-cherry-pick-of-#101763-upstream-release-1.19 branch from e88e31c to 7b3b4fb Compare May 6, 2021 17:45
@robscott
Copy link
Member

robscott commented May 6, 2021

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@robscott
Copy link
Member

robscott commented May 6, 2021

/assign @freehan

@aojea
Copy link
Member Author

aojea commented May 6, 2021

ping @kubernetes/release-managers

hasheddan
hasheddan approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@swetharepakula
Copy link
Member

/lgtm

@freehan
Copy link
Contributor

freehan commented May 6, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, freehan, hasheddan, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021
@puerco
Copy link
Member

puerco commented May 6, 2021

/test pull-kubernetes-e2e-kind

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 6, 2021
@feiskyer
Copy link
Member

feiskyer commented May 7, 2021

@aojea add a release note for this change?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 7, 2021
@aojea
Copy link
Member Author

aojea commented May 7, 2021

/retest
storage tests

@k8s-ci-robot k8s-ci-robot merged commit 3f263e1 into kubernetes:release-1.19 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@thockin thockin Awaiting requested review from thockin

1 more reviewer

@hasheddan hasheddan hasheddan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@robscott robscott

@freehan freehan

@swetharepakula swetharepakula

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
8 participants
@aojea @k8s-ci-robot @robscott @swetharepakula @freehan @puerco @feiskyer @hasheddan